Skip to content

Extracted RemoteServiceConfigurationProvider. #9350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

hikalkan
Copy link
Member

@hikalkan hikalkan commented Jun 16, 2021

This will allow the developer to dynamically determine the remove service configurations (like URL of a remote service).

@maliming
Copy link
Member

maliming commented Jun 17, 2021

It is best if we can make IRemoteServiceConfigurationProvider async. But IServerUrlProvider is sync now. We can consider refactor IServerUrlProvider.

https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.AspNetCore.Components.Web/Volo/Abp/AspNetCore/Components/Web/IServerUrlProvider.cs
https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.AspNetCore.Components.WebAssembly/Volo/Abp/AspNetCore/Components/WebAssembly/WebAssemblyServerUrlProvider.cs#L20

@hikalkan hikalkan merged commit 7f955b5 into dev Jun 23, 2021
@hikalkan hikalkan deleted the extract-RemoteServiceConfigurationProvider branch June 23, 2021 07:19
@hikalkan
Copy link
Member Author

Made it async with #9406

@slarkerino
Copy link

@hikalkan Hi, is it possible to use this with consul to dynamically discovery service url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants