Skip to content

postgresql connection string updated #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

can-guven
Copy link
Contributor

error : Keyword not supported: minimumpoolsize (Parameter 'keyword')

@maliming
Copy link
Member

Can you check #7562

@can-guven
Copy link
Contributor Author

I think you can use display name or property name as keyword.

These code are same for pool sizing:
Property Name Usage
return "Host=localhost;Port=5432;Database=MyProjectName;User ID=root;Password=myPassword;Pooling=true;MinPoolSize=0;MaxPoolSize=100;Connection Lifetime=0;";

Display Name Usage
return "Host=localhost;Port=5432;Database=MyProjectName;User ID=root;Password=myPassword;Pooling=true;Minimum Pool Size=0;Maximum Pool Size=100;Connection Lifetime=0;";

@maliming maliming self-requested a review May 13, 2021 07:14
@maliming maliming added this to the 4.3-patch milestone May 13, 2021
@maliming
Copy link
Member

hi

We can keep it simple. developers can add pool config if needs.

@maliming maliming merged commit 1c99db6 into abpframework:dev May 13, 2021
@maliming
Copy link
Member

@can-guven Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants