Support option child element for abp-select tag #8781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://stackoverflow.com/questions/67172053/empty-items-for-abp-select
Changes:
selectTagHelperOutput.Content
tochildContent
fromoutput
inAbpSelectTagHelperService.GetSelectTagAsync
:var selectTagHelperOutput = await selectTagHelper.ProcessAndGetOutputAsync(GetInputAttributes(context, output), context, "select", TagMode.StartTagAndEndTag); + selectTagHelperOutput.Content.SetHtmlContent(childContent);
Add
[OutputElementHint("select")]
onAbpSelectTagHelper
so that<option>
child element is allowed at design time.Otherwise, we get the warning
Element 'option' cannot be nested inside element 'div'.
from Razor in.cshtml
files.You may need to restart Visual Studio for this to take effect.
Update the demo in
FormElements.cshtml
for https://bootstrap-taghelpers.abp.io/Components/FormElements.The demo is linked on https://docs.abp.io/en/abp/latest/UI/AspNetCore/Tag-Helpers/Form-elements.
Reference: https://docs.microsoft.com/en-us/aspnet/core/mvc/views/tag-helpers/authoring?view=aspnetcore-5.0#inspect-and-retrieve-child-content