Skip to content

Supports the use of multiple template rendering engines in one application. #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2021
Merged

Supports the use of multiple template rendering engines in one application. #8673

merged 5 commits into from
May 3, 2021

Conversation

maliming
Copy link
Member

@maliming maliming commented Apr 18, 2021 •
edited
Loading

Resolve #8651

The AbpTextTemplatingModule is depend on the AbpTextTemplatingScribanModule and AbpTextTemplatingRazorModule now.

context.Add(
  new TemplateDefinition(
      TestTemplates.HybridTemplateRazor,
      localizationResource: typeof(TestLocalizationSource),
      layout: null
  )
  .WithVirtualFilePath("/SampleTemplates/TestRazorTemplate.cshtml", true)
  .WithRenderEngine(RazorTemplateRendererProvider.ProviderName)

@maliming maliming added this to the 4.4-preview milestone Apr 18, 2021
@maliming maliming requested a review from hikalkan April 19, 2021 03:29
hikalkan
hikalkan requested changes Apr 26, 2021
View reviewed changes
@maliming maliming requested a review from hikalkan April 27, 2021 13:01
@hikalkan hikalkan merged commit dd02ffe into dev May 3, 2021
@hikalkan hikalkan deleted the maliming/multiple-template-engine branch May 3, 2021 13:12
@hikalkan
Copy link
Member

hikalkan commented May 3, 2021

Thanks for the implementation. Great feature!

hikalkan added a commit that referenced this pull request May 3, 2021
@hikalkan
Renaming for #8673
fdcfb50 
WithScribanTemplate to WithScribanEngine
WithRazorTemplate to WithRazorEngine
@hikalkan
Copy link
Member

hikalkan commented May 3, 2021

I've done some renamings: fdcfb50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan hikalkan approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4-preview
Development

Successfully merging this pull request may close these issues.

Supports the use of multiple template rendering engines in one application.
2 participants
@maliming @hikalkan