-
Notifications
You must be signed in to change notification settings - Fork 161
Update dependencies and add textWidget parameter to SignInWithAppleButton #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@IndigoSoftwares21 Thanks for the suggestion. I think we made the text a But over the years I have definitely also seen more custom SiwA buttons, like some using the app's font across all social logins (and not the brand-specific / default one per button). Could you quickly state you use-case, just to make sure we're solving the right thing here? (Also the |
Hello @tp thank you for your response, I used a text widget, because the current font style and sizing did not match my app's style/theme. We can leave a comment in the docs to let user's know the recommended font size. I will exclude my changes to the |
…hAppleButton" This reverts commit c9bab80.
Thanks. This is fine with me. I wonder how we don't offer a localized version of the "Sign in with Apple" text yet. Maybe we did only do it inside our apps, but there is a default translation for "Sign in with Apple" for all languages Apple support, so developers should use that. Maybe the blocker was that it would require a certain localization library as a dependency, which would make it a no-go, but maybe also Flutter change in the meantime and we could offer this now. What I would love then would be to have a builder instead, where the developer can pass a But this is all beyond the scope of this one, and we can start putting this in first. Thanks @IndigoSoftwares21. |
Is there any useful test we should duplicate for this functionality? Maybe just a simple rendering one (no need to for a golden test), that passes a widget like |
Couldn't add test to the original branch here, so did so in https://github.com/aboutyou/dart_packages/pull/464/files Still not sure if we would want this, or if we should rather encourage developers to use their own "base button" of their choosing and drop in a Because while it works fine in some standard cases, I could easily image some fonts needing more parameters (like padding) to make it fit in size and alignment with the logo (which is implicitly sized based on the height). Well, at least now developers could do a bit of that themselves with the |
This will help us come closer to our designed button |
Description: