Skip to content

Improve license detection #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 13, 2025
Merged

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 2, 2025

Add misc license detection, post-processing and --todo improvements.

Fixes #3707 Follow references to license files in package-ecosystem specific places (beside package manifests)
Fixes #3969 Fix license references bug and refactor to avoid code duplication

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Reference: #3707
Reference: #3970
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
* Do not include copyright statement in license detection
* Handle cases of license/trademarks not being present correctly

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the improve-license-detection branch from 3b7a1a5 to 3a97066 Compare June 5, 2025 14:25
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits for your consideration!

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the improve-license-detection branch from 76ae306 to cfb9140 Compare June 13, 2025 11:30
@AyanSinhaMahapatra
Copy link
Member Author

All green and feedback resolved, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 38cf1ad into develop Jun 13, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoneType not handled in add_referenced_license_matches_for_package Look in package-ecosystem specific key-files for referenced licenses and summary
2 participants