Allow calling copyright detection from text lines #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you ++ |
Signed-off-by: Jelmer Vernooij <[email protected]>
jelmer
force-pushed
the
slim-licensedcode
branch
from
41f1db2 to
f4a58ad
Compare
|
On Wed, Mar 03, 2021 at 09:35:26AM -0800, Philippe Ombredanne wrote:
Thank you ++
Can you add you DCO signoff?
(Alternatively it is OK to just paste here and I will push that too in the merge commit.)
Done.
…--
Jelmer Vernooij <[email protected]>
PGP Key: https://www.jelmer.uk/D729A457.asc
|
pombredanne
changed the title
|
All good. Merging!Thank you. Note that the test failures are not your making. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out detect_copyrights_from_lines(), allowing the copyright code to be
used without pulling in a lot of other libraries (like typecode).