Skip to content

fix: add missing semicolons to display attribute #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021
Merged

fix: add missing semicolons to display attribute #107

merged 1 commit into from
May 3, 2021

Conversation

KyleRoss
Copy link
Contributor

@KyleRoss KyleRoss commented Mar 5, 2021

In src/helpers/columnWidth/columnWidth.js, the display CSS attributes returned from display() is missing semicolons. When compiled, it leads to CSS errors when running the page through the W3 validator. For example, here is a CSS snippet generated by flexa that has this issue:

.gpjAiT{box-sizing:border-box;display:block;padding-left:calc(2rem / 2);padding-right:calc(2rem / 2);-webkit-flex:0 0 auto;-ms-flex:0 0 auto;flex:0 0 auto;-webkit-flex-basis:100%;-ms-flex-preferred-size:100%;flex-basis:100%;max-width:100%;display:block   align-self:auto;}

@ghost
Copy link

ghost commented Apr 30, 2021

@aaronvanston any chance of merging this and making a new release?

@aaronvanston
Copy link
Owner

@adamkingletgo @KyleRoss Thank you, will merge now and release very shortly!

Copy link
Owner

@aaronvanston aaronvanston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aaronvanston aaronvanston merged commit 894e29a into aaronvanston:master May 3, 2021
aaronvanston added a commit that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants