-
Notifications
You must be signed in to change notification settings - Fork 11
Add path for folders results when searching #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @Morikko , nice ! Thanks for the work, and for the suggestion. As I see some possible side-effects on the main table, I prefer to limit this to the results table. Also, this requires a few adaptations to work well with other themes where colors are not just white-ish and black-ish .. => Can you give me push access on https://github.com/Morikko/Bookmark-search-plus-2/tree/search-folders-add-path so that I can place there slightly adapted versions I made, and then you can verify ? |
Maybe opacity would be better than grey then. I invited you on the repo. |
Thank you. Yep, this is what I did. Check the files / modifications I made. Let me know if ok. |
Great ! I have the feeling that the Also, I have the impression that aligning at the start is better for readability (especially with the default path behavior, eg not reverse). What do you think ? |
I personally prefer the alignment on right as you initially did, that makes a better distinction. 10% might be a bit much yes .. but 6px seems too low ... something in between ? |
Okay let's keep right alignment now. We can try with 10px. |
Looks good, I uploaded then the latest with that small adjustment, and with content for 2.0.111 also to avoid conflicts. |
From my point of view I'd rather see the whole bookmark/folder text, the space is rather limited, and I don't even have as much as on the screenshot. If there was windowed mode of BSP2, then it would be great to see the path all the time for search results. |
Yes, do not worry, we are not cutting / reducing the bookmark or folder text. And yes, there is a windows mode of BSP2, by opening it in a tab (see the magnifier glass menu, or right click on the BS2 icon in the toolbar). |
All good, looking forward to using it! |
Done, 2.0.111 is out with the improvement, thank you, aaFn. |
Related to #207
Context
For some "generic words", the search results are not very explicit whereas it would be if the parent folder or the full path could be visible.
Even with the option which makes the path visible when you hover the mouse on the result, I ended spending too much times waiting the hover section to appear.
As I mostly do folder searches, I would prefer a faster solution.
Feature
Examples