Assorted Feature Requests

[Muddy7]

I don't know if it's OK to introduce several feature requests in one thread but, hoping it is, here goes:

1. It would be good to make Ctrl+Q user-configurable in the settings part of the Options page (I normally use Ctrl+Q for another app on my devices)
2. It would be nice if you could add the shortcut keys Ctrl+Z (for Undo) and Ctrl+Y (for Redo) to the keyboard options
3. It would be really neat if, in the Properties pop-up window from the Context Menu, you could add a field for path of bookmark or folder, e.g. Bookmarks Toolbar > Home > Cooking > Recipes > Pasta > Spaghetti > Sauces (that way, it would be SO dead-simple for simple dudes like me to see, remember and re-memorise the folder path ;-D )

Thanks!

[aaFn]

Hello @Muddy7 , no problem to put several things together. Now:

1. Ok, I'll see what can be done with https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/commands
   Just mind that many combinations are already taken natively by FF menus and features, that the add-on has no way to know that (it changes depending on the OS), and trying to override them may lead to unpredictible behavior depending on the combination you chose .. :-) (not counting about other add-ons competing on the same shortcut of course ..)
2. Unfortunately this is not something easy to do. The FF bookmarks API is not meant for that. In particular, a delete is really deleting things, there is no way to come back in the past ... undoing a delete could only mean "recreate", however there are attributes not accessible by the API like Tags, Description .. etc ... which would be lost as these are not exposed through the FF API and an add-on has no way to know about them. Another way could be to delay the delete, but then in the real native bookmark sidebar and manager, it would still show ... This requires careful thinking.
   So for now I will defer this one, and it would be best to list it independently in another issue to not lose it.
3. Ok, good idea.

[Muddy7]

Hello @Muddy7 , no problem to put several things together.

Thanks for clearing that one up. And thanks for saying it's OK :-))

1. Ok, I'll see what can be done with https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/commands
   Just mind that many combinations are already taken natively by FF menus

I'm aware of the usual culprits like Ctrl+A,+B,+C,+D,+E,+F,+H,+J,+K,+N,+O,+P,+S,+T,+V,+X (rather a lot—most of my editing has been my belatedly discovering new ones!!). Hope there aren't too many others :-( And I take your point about possible unpredictable behaviour... (Maybe give this one a miss?)

2. Unfortunately this is not something easy to do. The FF bookmarks API is not meant for that.

That's funny. I've just tested using the Delete key in the resident FF Bookmark Sidebar to delete a bookmark and then pressing Ctrl+Z and it worked perfectly. Then I pressed Ctrl+Y and it deleted again. Ctrl+Z and I got it back again.

3. Ok, good idea.

Brilliant! Thanks!

[aaFn]

That's funny. I've just tested using the Delete key in the resident FF Bookmark Sidebar to delete a bookmark and then pressing Ctrl+Z and it worked perfectly. Then I pressed Ctrl+Y and it deleted again. Ctrl+Z and I got it back again.

Yeah that is the problem, the native bookmark stuff has access to things not exposed to the API .. of which there is no undelete command on the API, and as I said, no access to Tags, Description, Keyword -> https://bugzilla.mozilla.org/show_bug.cgi?id=1225916

[Muddy7]

Yeah that is the problem, the native bookmark stuff has access to things not exposed to the API

Yeah I wondered if that was so. So, as you say, I should make this a separate request so it's not forgotten. And even then it may prove too complicated coding-wise to be feasible for a one-man operation like this. Hoping that's not so, but realising it may well be :-/

Thanks!

[aaFn]

I got some ideas based on a trashbin approach, but as said this requires careful thinking of the diversse possible cases, so not something that would come with a snap of fingers :-)

[Muddy7]

Great!

[Muddy7]

Btw I added yesterday my support to Issue #70 as the Folder Context Menu Option "Open All in Tabs" is the feature I most miss from the resident Bookmarks Sidebar. If I am not mistaken, it is the only operation I currently feel the need to toggle from BSP2 back to the resident Bookmarks Sidebar to use (which incidentally shows how good your Bookmarks Extension is :-))

[aaFn]

Both are now implemented in 2.0.46, let me know if ok.

[Muddy7]

Incredible! This morning (GMT+1=my time zone), in my hurry I hadn't noticed that you had not only implemented the issue in #73 (thank you!) but also issues 1 & 3 from this thread (issue 2 having been transferred to a new thread #75 as this requires further reflection by the developer before implementing—if feasible). I am truly impressed by the speed at which suggestions that are deemed acceptable are then implemented. Thanks!

And great to now be able to see the path in a flash! A great addition :-)

Btw (and this is a very minor point) personally I would have placed the path below the name and address in the Properties pop-up window. When it takes up just one line it's fine, but when it takes up more (which is often the case with my bookmark paths) it looks inelegant. However this is admittedly a minor aesthetic issue and maybe a matter of purely personal taste ;-) Also perhaps, to cater for everyone particularly those who don't know any computer jargon, change the label from "Path" to "Location"?

[aaFn]

Maybe "Folder path" to be more explicit ? Or simply "Parent folders" ?

On its position, indeed, that could be below the two other fields .. I just thought it was logical to show the series of folders leading to the item, and the item name just after. I didn't look at aesthetic considerations so far.

[Muddy7]

As I say, a very minor point indeed. But I stand by my preference for placement in pop-up window. Personally (for others it might be different! As I said, personal tastes may vary) the first thing I would like to see is the name of the bookmark. Then where it is on the internet. Finally where it is located in my bookmark tree structure.

Regarding "Folder path" or "Parent folders", why not? For me, "Path" is crystal clear. Just thinking of those who don't know any computer jargon at all ;-)