Bookmarks tree loading stuck on windows7 / FF56.2 (64bit)

[EmilianoCostantini]

With reference to https://addons.mozilla.org/it/firefox/addon/bookmark-search-plus-2/reviews/1072678/

---

◆TRACES

PlatformOs: win
Setting Windows variations
Load duration: 3365 ms

---

◆CONSOLE OUTPUT

TypeError: BTN.url is undefined[Further info]  panel.js:659:9

[Exception... "Illegal value"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/ext-tabs.js :: query :: line 487"  data: no]  (unknown)

Unchecked lastError value: Error: An unexpected error occurred  ExtensionCommon.jsm:304

Error: WebExtension context not found!  ExtensionParent.jsm:778:13

Error: Could not establish connection. Receiving end does not exist.  undefined

Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist.  ExtensionCommon.jsm:304

[aaFn]

Hello @EmilianoCostantini , thank you.
Well, that means you have a bookmark without a URL .. strange.

I will protect the code against such occurrences, but then I would be curious to understand what is this oddity ... so I will trace it.

That will be in 2.0.9 .. and then if you agree I would ask that you take again a trace .. and post it here.

[aaFn]

@EmilianoCostantini , 2.0.9 is out .. if you can retest with it and paste traces / browser console here ?
Thank you in advance.

[EmilianoCostantini]

2.0.9 tested, loading still stuck, the loader keeps on rolling endlessly.

About the bookmark withour URL, it may have been created by this addon -> https://addons.mozilla.org/en-US/firefox/addon/link-password/

◆TRACES

PlatformOs: win
Setting Windows variations
Load duration: 2765 ms
Odd bookmark item encountered !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  toolbar_____,Bookmarks toolbar,2,1383691094156,root________,1520935656102,
Bookmark with undefined URL !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  toolbar_____,Bookmarks toolbar,2,1383691094156,root________,1520935656102,
Odd bookmark item encountered !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  menu________,Bookmarks menu,1,1383691094156,root________,1520862754020,[object Object],[object Object],[object Object],[object Object],[object Object]
Bookmark with undefined URL !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  menu________,Bookmarks menu,1,1383691094156,root________,1520862754020,[object Object],[object Object],[object Object],[object Object],[object Object]
Odd bookmark item encountered !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  unfiled_____,Other bookmarks,4,1383691094156,root________,1520240855887,
Bookmark with undefined URL !
  id,title,index,dateAdded,parentId,dateGroupModified,children
  unfiled_____,Other bookmarks,4,1383691094156,root________,1520240855887,
Display duration: 46 ms
fontFamily = '"Segoe UI"'
fontSize   = '12px'
Stats:
------
Bookmarks:  0
Folders:    0
Separators: 0
Oddities:   3
--------------------
Save duration: 24 ms

◆CONSOLE OUTPUT

TypeError: BTN.url is undefined

[aaFn]

Ouch !

Something is wrong .. these are folders, they should have a "type" field set to "folder" .. this field is missing .. I only see id, title, index, dateAdded, parentId, dateGroupModified and children.
See https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/BookmarkTreeNode

Now I understand better why this is failing.

I can look at trying to work around that in the code for robustness, but I wonder if this is not a special case that you have and if there are not some other oddities going to fail anyway ..
Well, I am in business travel for now, so can't modify that before I get back home for the week-end .. will come back to you on Saturday or Sunday.

Thank you for the data.

[aaFn]

Hello @EmilianoCostantini , 2.0.10 should be out tonight with robustness features to resist to the above.
When you have updated, let me know how this is going, I hope I trapped all the cases ..

[EmilianoCostantini]

Thank you, aaFn!

Unfortunately this time a modal window appears, notifying me that a script has stopped working and asking me if I'd like to open it in the debugger or let it run.

Note that my bookmarks are synced (via the built-in Firefox tool) between 2 computers:
--Linux Lite 3.6 / FF 49 (64 bit)
--Windows 7 / FF 56.0.2 (64 bit)
So the bookmarks are the same, but the problem happens only on Windows.

◆TRACES

PlatformOs: win

Setting Windows variations

Load duration: 3562 ms

Odd bookmark item encountered !
  id,title,index,dateAdded,parentId,url
  bIhhk1In0tPo,Numeri di emergenza e pubblica utilità,0,1393276494000,kG_r5sdmi6HM,http://www.comune.milano.it/portale/wps/portal/CDM?WCM_GLOBAL_CONTEXT=/wps/wcm/connect/ContentLibrary/Ho%20bisogno%20di/Ho%20bisogno%20di/numeri%20utili_numeri%20di%20emergenza%20e%20di%20pubblica%20utilita&categId=com.ibm.workplace.wcm.api.WCM_Category/IT_CAT_Bisogni_43/e3240e8044ffb8358fcabf51a173c8e3/PUBLISHED&categ=IT_CAT_Bisogni_43&type=content

Odd bookmark item encountered !
  [...]

And so on and so forth, with an endless list of Odd bookmark items encountered.

[aaFn]

Hello @EmilianoCostantini , ok at least this is progressing .. now I see the type field is missing on bookmarks also .. I will have a look at it tonight and get 2.0.11 out to cope with that also .. I hope the problem is not also on separators, else that will become more complex to manage ..

When you say "built-in Firefox tool", do you mean https://www.mozilla.org/en-US/firefox/features/sync/ ?

[aaFn]

Ok, 2.0.11 is out, can I ask you to try again, and post here the traces and also the Browser console output ?
Let's see if I got it better this time or if somethings remains ..

[EmilianoCostantini]

2.0.11 tested! The loading works now, and pretty fast! :)

◆TRACES:

PlatformOs: win
Setting Windows variations
Load duration: 2706 ms
Display duration: 2224 ms
fontFamily = '"Segoe UI"'
fontSize   = '12px'
Stats:
------
Bookmarks:  6839
Folders:    892
Separators: 0
Oddities:   15462
--------------------
Save duration: 235 ms

There seems to be still a problem with separators; I have a great many of them, but they don't seem to get detected.

Furthermore, right-clicking on an existing bookmark does not show any context menu, nor dragging the ⓘ or the tab creates a new one as expected.

◆CONSOLE:

TypeError: Argument 1 of StructuredCloneHolder.deserialize is not an object.[Ulteriori informazioni]  ExtensionChild.jsm:786:24
Error: WebExtension context not found!  ExtensionParent.jsm:778:13
TypeError: Argument 1 of StructuredCloneHolder.deserialize is not an object.[Ulteriori informazioni]  ExtensionChild.jsm:786:24
Error: WebExtension context not found!  ExtensionParent.jsm:778:13
Error: Type error for parameter bookmark (Unexpected property "type") for bookmarks.create.  panel.js:3101:9
Error: Type error for parameter bookmark (Unexpected property "type") for bookmarks.create.  panel.js:3059:10

All in all, I'd say this release is a major improvement! Thank you for the precious work, aaFn! :)

[aaFn]

Hello @EmilianoCostantini , that is weird !!
type is a native property supported by bookmarks.create(), see https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/create

The only thing I can think of is that FF 56 does not have the full API .. I will see if I can check that by downloading an old version ..

[aaFn]

Ok, I just checked, and indeed, this is FF 56 which does not have the full support of the API.
I can see also that some features I am using for favicon retrieval are not present in FF 56.

=> Would you mind upgrading to FF 57 or higher ?
On my side, I should raise the minimum requirement for the add-on from 54 to 57 I guess ..

[aaFn]

@EmilianoCostantini , for the sake of versatlity, I added the best support I could to FF56. However thare are limitations because the API does not support well separators until FF 57 and higher:

• I have to make separators non movable and non deleteable.
• There is no way to create a separator in the API, so that operation is not supported.
• And there are cases where we can't know that there is a separator, typically when the separator is the last item in a folder.

Some other limitations/bugs like:

• New tabs cannot refer to a parent tab, so they are always created at end, and not besides current open tab.
• Or open bookmark in a new window does not get the sidebar loaded, you have to go to the menus or to use the shortcut key to force their loading.
• Plus probably some others I didn't catch .. let me know if you see annoying things ..

Anyway here it goes in 2.0.12 .. enjoy in spite of the limitations .. but I strongly advise you upgrade to FF57 or higher.

Let me know if ok or not .. on my side I am changing the setting of the add-on to be 56 minimum instead of 54 to avoid other bad surprises ..