Feature Request: Filter to sort Search result by type (Folder, or bookmark)

[brain8891]

Having a filter button to sort by type in the Sidebar within the search result:
Reason: To search for a folder to save a bookmark in it.

Another unrelated Feature request:
Displaying the full path of a folder when hovering over it.
Reason: In my case, sometimes I have many identical named folders, for example, under each country I would have list of categories of governmental offices or popular E-commerce websites etc.
an example:
Bookmarks Toolbar/Country A/CategoryA
Bookmarks Toolbar/Country B/CategoryA

So if I was on webpage and wanted to bookmark it, in "CatergoryA" I would get two results, so having this feature would help to find the right folder without clicking on them.

lastly, Thank you for your hard work, BSP2 really made my life easier.

[aaFn]

Hello @brain8891

On 1) = I will look if there is an easy way for that, for now I have no sort algorithm in search, it display things in the order they are received from the API call (like the native Bookmarks sidebar I believe)

On 2) = did you try the On mouse hover above search result, show path to bookmark item instead of title + url option ?

Thank you, aaFn.

[brain8891]

On 2) = did you try the On mouse hover above search result, show path to bookmark item instead of title + url option ?

Pardon me, it didn't came to, I should've checked the Options firsts.

On 1) = I will look if there is an easy way for that, for now I have no sort algorithm in search, it display things in the order they are received from the API call (like the native Bookmarks sidebar I believe)

I hope, and again my apologies.

[aaFn]

Hello @brain8891 , on 2), I can propose in fact to realize that with filters:

• filters already exists
• they are activated through the drop down menu on the magnifying glass (right or left click, both work)
• in there, I would add a "dimension" with 3 choices:
  • All (default)
  • Folders only
  • Bookmarks only

How does that sound ?

[brain8891]

in there, I would add a "dimension" with 3 choices:

That is perfect, please do that. However I notice several issues, and I hope you would consider them.

they are activated through the drop down menu on the magnifying glass (right or left click, both work)

The magnifying glass indicate a search button, and it always confused me, to emphasize that point; Even though I found out about it many times, I keep forgetting about it many times again, just not intuitive to me and I think most users. Also that lead new users to a bad initial experience, so I hope you consider changing it to a standard filter Icon, or just having the word filter, and when choosing regex or folder filters, it would put an icon beside the word "filter":

How it looks on Github.com:

Two standard or common filter icons (research more):

Having said that, I got used to it, and I love how the color changes, but I think new users will have trouble, hence my suggestion. The initial experience is very important in user experience.

furthermore, I wanted to understand better BPS2 before I give my feedback, so I read:
https://github.com/aaFn/Bookmark-search-plus-2/wiki/Advanced-searching-documentation-(as-of-2.0.65-)
(found a typo, just search for [macth] and replace it with [Match])

To test, I made a folder with a bookmark and tried to use all the filters in BPS2 except regex. Here is a list of what I found, I know I should open a "new issue" for each, but there were several. and I think it is faster to enter them here, sorry about that. If it is necessary ask, and I will create a "new issue" for each.

1- In BPS2 Sidebar you get full context menu, but not when in a new tab:

Screenshot of SideBar context menu:

Screenshot of new tab context menu:

2- BPS2 remembers the filters used even after closing and reopening BPS2, It might create a problem where users would forget that the filters are active. I am not sure what is a good solution, here is some that comes to mind:
A. Having a setting in BPS2 Options where users can set the filters to be remembered after closing BPS2 and by default this settings should be turned off.

B. In the drop down menu on the magnifying glass a check mark at the top or bottom of the list to [always remember filters] if not checked then when closing BPS2 it would reset the filter back to default.

C. The why I prefer it, is to have it the default way for most users, and have the [always remmeber filters] check mark in the context menu, with additional inline search operators similar to Google Search and Github search for advance users:
github:

Google Search:

For example: I could type $folder Test, or $bookmark $title Jibname.com (which will search for only bookmarks, with the title jibname.com)

3- changing the filters requires the user to type the search query again. For example: I would search for Jibname which was in the test folder, and I would change filters, but it would remove Jibname from the Search bookmarks.. filed. I think it should remember the searched query because most filter buttons do that in almost all search engines, and applications, so it will not be intuitive as most users are used to that norm.

4- The Terminologies used in drop down menu on the magnifying glass and in BPS2 property window, doesn't match Firefox's terminologies for bookmarks, even though I rather you not changing it because it sound better :) but it might affect novice users and might confuse them specially if they moved form a different browser.
here is Firefox's Terminologies

This is what BPS2 use in Property window:

This is what BPS2 use when clicking the magnifying /"filter" button:

So title is Name in Firefox, and URL is location.

if you will not change these, one thing you must which is change the Address and Name in the property panel to URL and title or vice versa, as it should be consistent through out BPS2 that is a must, as it is against standards and it will severely affect UX

5- the property panel changes to a different location every time I open it, and sometimes off screen which makes me not want to use BPS2 property window, hence, I use the default property window in FF and also because I can't modify Keywords, and Tags, I hope Mozilla let add-ons have access to at least the Tags as then I can search BPS2 using search Tags too.

description of what happens: when I right click a bookmark> click prosperities> then a smaller window appear on top right side of my screen then moves to somewhere random, sometimes to the far corner of the screen(check the second screenshot)
screenshot1:

screenshot2: even though I brought it to middle it still goes somewhere off the screen

solution: If possible it should always appear in middle of the screen.

6- the property window have no clear title (just Mozilla Firefox) which makes it harder to find in windows taskabr:

windows taskbar:

solution: this is possible through web extension API, I suggestion just change it to Properties of "the bookarmrk title or name", or to Bookmark Properties

lastly, thank you again for your hard work, I hope I helped as well.

[aaFn]

Hello @brain8891 , plenty of feedback and good catches 😀, thank you. Let me address them one by one:

0. On the filter button / icon:
   1. I want to remain with limited estate. So adding "Filters" at front of it is too big (and depending on language when I will translate one day, it will vary in size, not so good).
   2. Also, its design changing with the type of filters applied (icon image, color, fill degree), and varying on 3 orthogonal dimensions (currently, because adding folders and bookmarks will add a 4th dimension, not completely orthogonal to Title and URL by the way ..), then it won't fit with a filter icon inside it.
   3. Maybe I could do the following:
      • Add another fixed icon in front of it = limited estate, take one of the icons you suggest for example.
      • Make it a button also, add a floating bubble "Reset filters", and when pressing on it, it will clear any active filter and go back to all defaults.
      • Remove the BSP2 version floating bubble on the current button, and replace it by a floating bubble containing "Filters: ..." and then some text describing the applied filters, or "none" when no filter.
      • Let me know your thoughts
   4. By the way I corrected the typo (macth) in the documentation, thank you.
1. Indeed, this is a regression .. I corrected in 2.0.79 which should be out tonight.
2. I guess 0.iii) above should address the problem, since there would now be a button to reset to all defaults, and the button to modify filters would contain text describing active filters (not modifiable directly, but only by pressing on the button and changing choices).
3. Ok, good point, I added this improvement to 2.0.79.
4. Indeed, I didn't notice that I was using several conventions. As (like you I guess) I do not love the "Name" + "Location" of Firefox native sidebar, I can propose the following, let me know your preference or suggestion:
   1. Title + URL everywhere (more technical)
   2. Name + Address everywhere (closer to FF, note that in French version of FF, it says "Adresse" where the English version says "Location")
5. I do not get that effect. I suspect you may be hitting the same problem than Bookmark Properties Window opens "full size" #148. Are you using user_pref("privacy.resistFingerprinting", true); ?
6. Same, this seems typical of the finger printing resistance feature, see on standard profile like mine, it is already as you want it:
   

Let me know if I missed something.
Thanks, aaFn.

[aaFn]

By the way, 2.0.79 is out, so 1) and 3) are done, remain the main subject of that issue + 0) (which willl handle 2)) + 4)

[brain8891]

Hello @aaFn, I updated to 2.0.79

0- about filter Ion

I am confused about certain things:

I want to remain with limited estate. So adding "Filters" at front of it is too big (and depending on language when I will translate one day, it will vary in size, not so good).

I agree, but I wanted to give you a list of options out there

Also, its design changing with the type of filters applied (icon image, color, fill degree), and varying on 3 orthogonal dimensions (currently, because adding folders and bookmarks will add a 4th dimension, not completely orthogonal to Title and URL by the way ..), then it won't fit with a filter icon inside it.

I am not sure what you mean by Orthogonal dimensions?
do you mean adding splitting the icon color as in these two screenshots? :

Add another fixed icon in front of it = limited estate, take one of the icons you suggest for ex.

What do you mean by ex?

And by in front of it you mean the current filter button?

Make it a button also, add a floating bubble "Reset filters", and when pressing on it, it will clear any active filter and go back to all defaults.

I think this point is related to the point containing ex so you mean basically having two buttons, one for list of filters and one to reset to default filters, is that what you are saying?

Remove the BSP2 version floating bubble on the current button, and replace it by a floating bubble containing "Filters: ..." and then some text describing the applied filters, or "none" when no filter.

YES! DO THAT

let me try to explain further and how I think it should be:
to filter by folders use column similar on how it is on Windows File Explorer search result:

image one:

Image two:

Or have it as an entry in the filter button:

However personally I rather go with the first option (columns) as it is faster, makes the filter context menu less cluttered, and in future when web extension let addons access tags, visit count, most recent visit, and last modified these columns could be added to the BPS2 new tab for more detailed search.

Also, add in options a setting to remember "search columns" sort order:
(Not sure how to phrase it)

About Remembering filter choices, the floating bubble message is perfect, but along with that have a setting in Options whether to remember or forget filters when BPS2 sidebar/newtab is closed

I prefer having a button beside the filter button to reset the filters as in the next image:

you also can do this:

about the Icon, I think you didn't understand what I mean by the Icon, I am talking about the filter button Icon

Inside of it there is a magnifying glass which doesn't indicate filters I suggested to change it to something like this:

or this:

conventionally these icons represent filters and a magnifying glass is to search or open search button:

1- about sidebar context menu not matching the New tab context menu: SOLVED

3- great, now I can apply different filters without the need to retype it: here is something that should be listed for future update, it is low in priority:
While testing issue 3 ,I saw no indication that BPS2 is searching, so, what if the user have a huge database and it takes time for the filter to be applied? I think there should be a circular loading animation or better just text Searching... while the three dots are animated, many applications do that:

This should be low in priority.

4- about using different conventions for bookmarks URLs and Titles: usually you should stick to one convention, that is what user experience dictates, however, here it is complicated. I rather the technical one, URL+Title everywhere because that what they are, I don't know why FF went for Name and Location.

And, I did check Chrome and Opera, not edge because who cares, and I think you can stay with URL+Title when it come to filters, but for the bookmark property window:

I rather see Name/Location, this will create less confusion for more casual users who might install BPS2 in future, you don't want them confused. or you can do this:
Name/title:
Location/URL:
only in the Bookmark property window, and the filters keep as it is. That is what I would do. both technical and conform with Mozilla's decisions.

Do what you think is right, but the address should be changed to location, that what Mozilla chose for English users.

5- privacy.resistFingerprinting is set to false

I read #148 I am not sure, I am confused, the issue I am facing is different and similar to an extent. Every time I open and close Bookmark property window it gets larger and move down to right.
when this setting is checked: ( I checked it after reading #148 which didnt really solve the issue for me)

And when it is unchecked:

it moved down tp right without the windows getting larger

I am not sure how to help here. if you suggest something to troubleshoot this let me know.

Another thing which is not a big deal, but aesthetically I hate seeing the two flashes of window resizing, a small window appears somewhere on top then moves down. I noticed that unconsciously this window flashing twice in my face makes me use it less. I think other users feel the same.

Alternatively, for now if this is hard to fix, have a temporary fix as this will push away many new users. after sometime it goes off screen

6- I think you are on linux or something else on Windows the title of the window is "Mozilla Firefox":

if I recall correctly, I think it is possible for Add-ons to change the window title. I suggest changing it to Bookmark Proprieties of: example.com
this way if you have several window of Firefox open you can find the property window faster in windows' taskbar.

New bug, and issues:

7- Bug: in newtab> right click> New folder.. AND New bookmark.. AND New separator > doesn't function

8- in sidebar> right click> New Bookmark..> it doesn't add http:// automatically similar to how firefox works:
Firefox:

BPS2:

I suggested replicating how Firefox handle it, but if you have a reason not to, then don't let the input field have a red stroke and the add button disabled without any context, there should be a displayed error message to guide the user to add http:// manually. I emphasize replicating Firefox builtin behavior which is more intuitive and user friendly!

9- just a question about Favicon, why should it be fetched, can it be be fetched from places.sqlite?

10- some thoughts for future, you don't have to reply to this:
I hate how Firefox or any browsers handle bookmarks, you can't even add descriptions anymore, and if I relied on an addon, it means that if that addon ceased to exist I will lose all the descriptions added. is there away? I am considering Zotero as a bookmark manager, but that is an extra layer of inconvenience.

Also, I wonder if it is possible to assign custom favicon to EACH folder, like different colors, appending a letter to them, or just enter a URL to fetch that particular favicon, it would make it easier to spot, but the problem is if you implement that, it will be viewed and stored only by BPS2 if it is possible to also these custom folder within FF bookmark manager it would be a useful feature as it will help to spot certain folders in a long list of bookmarks.

Thank you for your hard work.

[aaFn]

Hello @brain8891 , thanks. Here are quick answers:

0. In details:
   1. 3 dimensions = filter on bookmark content (all, title only, url only), on scope (full tree / subtree), and using different methods (word or regex).
   2. Orthogonal = you can chose any value in each dimension without affecting the others.
      Filtering on type (all, folder only or bookmark only) will be a 4th dimension, but not completely orthogonal because when "folder only", you cannot select "url only" in the first dimention.
   3. Each dimension has its own distinct sign: 1st dimension is varying the fill ratio, 2nd dimension is varying the icon, 3rd dimension is varying the color. All can be mixed independently. Adding a 4th dimension, I have to think of another characteristic in the button which is neither the fill ratio, neither the icon, neither the color ... (I already got an idea, that would be the form of the button, I need to test)
   4. "for ex" was meaning "for example", sorry for the abbreviation, I just corrected.
   5. Yes, two buttons, as you illustrated
   6. Magnifying glass icon = I use it to match FF icon when we are in default mode, because this reproduces the FF search behavior. I prefer not to change it. However, the button I will add at front can have any icon, I think I'll take the one with the 3 lines and circles.
   7. Sorting: I do not have any sorting algorithm at output of the search, and for now do not intend to add one. All you say is good, but I will keep that for future maybe. Hence my proposition to add that as filter instead for now.
1. /
2. /
3. There is a waiting icon already (a circling dot icon), simply I guess things go too fast for you to see it. Try by typing only 1 common character like "a" in the search box and wait .. you should see it 😀
4. I like the
   Name/title:
   Location/URL:
   suggestion, I will take it, thanks
5. I can't reproduce the behavior you explain, neither on Windows 7, neither on Windows 10, neither on Linux. Something else must be going on. Would you be able to try launching Firefox with a new blank profile to verify ? Keeping yout current profile of course, see https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles?redirectslug=Managing+profiles&redirectlocale=en-
   • No fix for the flashing problem, not even temporary .. this is the way FF is acting, I couldn't find any way to get around it so far.
6. Yes you are correct, add-ons can set the title on the window and I do it in BSP2. I do not know why this doesn't happen in your case. If you test with a blank profile, I'd be interested to see if you still get that problem.
   Note: the picture I showed you in my previous answer is on Windows 10. It works also ok on my side on Windows 7.
7. Indeed .. I'll chase the bug, thanks.
8. Ok, I'll check it is easy to do that, I didn't catch FF was adding http:// automatically when not present.
9. Nope, no access to places, nor sqlite, see https://bugzilla.mozilla.org/show_bug.cgi?id=1315616 and https://bugzilla.mozilla.org/show_bug.cgi?id=1411120
10. Indeed, that would be custom and I confirm it would remain not exportable outside the add-on to FF bookmark manager. At least for the same reason than 9. ...

Thanks for the detailed feedback, let me know the result if you can try with a blank profile for 5) and 6).
Cheers aaFn.

[brain8891]

5- This is on a fresh profile!? It just is so random, that I am not sure what is going on. I am not sure about this, but I think when I pressed save it would move less toward down right. If you explain how the code works, maybe I can test it more.
so, when the user click on save and cancel, is there any code about the window position changing?

6- This is on a fresh profile!?

[aaFn]

Ok, glad to see that 6) is working well on a fresh profile, so there must be something in your normal profile which is disabling the window title.

On 5), I do not know what is going on. the code simply saves the position on window close, so that next time it opens at same position.
An idea =... is there any zooming factor active somewhere, in Firefox or in Windows ? (different from x1)

[brain8891]

5- The issue is related to Windows DPI, mine was set on 125% and I changed it to 100% and it fixed the issue, I assume the same issue persist on all versions of windows.

6- found out the problem, it is caused by:
https://addons.mozilla.org/en-US/firefox/addon/window-titler/
https://github.com/tpamula/webextension-window-titler
I think it would be better if you open an issue there after you investigate.
to reproduce: Go to Window Titler and just change any of the settings there, it is quite random, I am not sure what is causing it. in the test profile, sometimes the title would comeback after I change the settings again.

[aaFn]

Hello @brain8891 , thank you for this detailed feedback, I will investigate the DPI problem then to see if I can get around it, this is helpful 😀

[brain8891]

It is an honor hearing this, and YOU made my life easier.

Additionally about issue 6, I tested it on a fresh profile and initially things were okay, but I had doubts, so I opened several windows and gave the different "titles", but that didn't seem to affect BSP2,
It happened after I played around with the Windows Titler options. But I couldn't understand how or why, and that why I thought it is better to bother you with opening a new issue at [https://github.com/tpamula/webextension-window-titler]

Again thank you very much for your hard work

[aaFn]

Hello @brain8891 , ok thank you, I found an inconsistency on the FF API related to system DPI settings / zoom factor.
Namely, and for the records, the ratio is impacting window.devicePixelRatio,, but not window.screenX and screenY, so this is leading the BSP2 code to shift and scale the property window when the system scale ratio is different from 1.

I worked around it, as I am not too sure if this is normal and I am interpreting specs incorrectly, or an FF bug. That will be in 2.0.80. I tested on Windows and Linux, seems ok.

I don't know about Windows Titler, I do not use that, and do not really feel the need. If it changes window titles, I am not surprised this can affect BSP2 windows in some way, but I guess this is the choice of that add-on developer and its users to modify things as they want. If something is going wrong in it, then its users should signal the bug. As I am not using it, I do not feel entitled to say what is wrong or what is right with it.

[brain8891]

@aaFn Intersteing, When 2.0.80 is out let me know to test it.

Windows Titler: you are right, I will open an issue, as it should not remove the title of a window randomly