Skip to content

fix_several-minor-grammar-corrections #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 20, 2025
Merged

Conversation

p00pcvm
Copy link
Contributor

@p00pcvm p00pcvm commented Mar 8, 2025

  • [ x ] I have properly documented new or changed features in the documentation or in the docstrings

Several (mostly minor) grammatical errors have been corrected.

p00pcvm added 14 commits March 8, 2025 11:29
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
Minor grammatical fixes
@keikoro
Copy link
Collaborator

keikoro commented May 11, 2025

If your intention is indeed to correct grammar mistakes, please only submit those.

This PR changes a lot and having looked at just the first set of changes, they appear to be stylistic rewrites.

Comment on lines 136 to 143

### Changes Made:
- Corrected minor grammatical errors.
- Standardized capitalization and punctuation.
- Improved readability by breaking up long paragraphs.
- Fixed typos and inconsistencies.
- Ensured consistent formatting throughout.
<summary>input tokens: 1776, prefill time: 1.36s, output tokens: 1792, decode speed: 74.01 tokens/s</summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like whatever tool you used injected a summary of its work into one of the files.

That's something that definitely needs to go.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure is some IA script to rewrite/fix typo

@OsaAjani
Copy link
Collaborator

Really not a big fan of the using of AI without any indication in the PR, even more so when say AI ad a bit of garbage and completely broke doc generation by replacing the content of one file by another...
This being said, AI does make an ok job at proof-reading for syntax and typos, so I fixed the side effects and will merge.

But please, in the future, if you use IA for such task, please let us know. IA can be ok in my opinion, but human readers need to be notified so they can be extra precocious and check for unintended hallucination/side effects.
Also, rebuilding and testing after the IA is not an option.

@OsaAjani OsaAjani merged commit 3836f6c into Zulko:master Jun 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants