-
Notifications
You must be signed in to change notification settings - Fork 14
feat: adds release mode docs to repack doc #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
407879e
to
42edde5
Compare
42edde5
to
bf84dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
{/* TODO: set ZC for iOS */} | ||
{/* - For iOS, you can use the following command: */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to fix this
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
Co-authored-by: Lois <[email protected]>
…rCloudIO/zephyr-documentation into feat/rn-repack-release-doc
- Bundle the MiniApp: | ||
|
||
```bash | ||
ZC=1 pnpm --filter MiniApp bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZC=1 pnpm --filter MiniApp bundle | |
## bundle towards ios | |
ZC=1 pnpm --filter MiniApp bundle:ios | |
## bundle towards android | |
ZC=1 pnpm --filter MiniApp bundle:android |
to help us isolate platform deploy
- Bundle the HostApp: | ||
|
||
```bash | ||
ZC=1 pnpm --filter HostApp bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZC=1 pnpm --filter HostApp bundle | |
## bundle towards ios | |
ZC=1 pnpm --filter HostApp bundle:ios | |
## bundle towards android | |
ZC=1 pnpm --filter HostApp bundle:android |
ZC=1 pnpm --filter HostApp bundle | ||
``` | ||
|
||
- Command run with `ZC=1` will upload the bundles to Zephyr Cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Command run with `ZC=1` will upload the bundles to Zephyr Cloud. | |
- Command run with `ZC=1` will deploy the bundles to Zephyr Cloud. |
Claude finished @Thegrep01's task —— View job PR Review: Release Mode Documentation for RepackTodo List:
Purpose Summary: This PR adds comprehensive documentation explaining how to configure and run React Native applications with Re.Pack in production/release mode using Zephyr Cloud for bundle deployment. Review Findings
**Detailed Analysis & Recommendations**Critical Issues
Documentation Quality Issues
Security Considerations
Code Quality Improvements
Positive Aspects✅ Comprehensive Coverage: The documentation covers the complete flow from configuration to deployment Recommendations for Improvement
Overall Quality Score: 7/10Top 3 Next Steps:
The documentation provides solid value but needs completion of critical sections and security improvements before merge. |
What's added in this PR?
Adds guide how to run app with repack in release mode
What's the issues or discussion related to this PR (optional) ?
[Provide some background information related to this PR, including issues or task. Prior to this PR what's the behavior that wasn't expected.]
[If there wasn't discussion related to this PR, you can include the reasoning behind this PR of why you did it.]
Feature related update for this PR (if applicable)?
(Optional) What's left to be done for this PR?
Who do you wish to review this PR other than required reviewers?
(Required) Pre-PR/Merge checklist