Skip to content

Update build.yml (hopefully slightly simplified) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Update build.yml (hopefully slightly simplified) #75

merged 4 commits into from
Oct 18, 2024

Conversation

blubbsy
Copy link

@blubbsy blubbsy commented Sep 30, 2024

Here agian the text from #73:

I "updated" the kibot action to generate the production files:

changed to use the latest ubuntu version
changed to use the latest kibot thingie.
Reduced the dependencies to only check out Kampi's library
--> the oficial kibot container, has all dependencies included

i dont know why, but the artificat zip files are bigger now, but i unpacked them and couldnt find any difference (the size is then identical). I assume that it has something to do with the container...

Does it make anything better? To be honest: i dont think so, but i hope that using the container reduces potential compatibility problems or to find potential problems with an KiCAD update.

This reverts commit defd07d, reversing
changes made to 67b4a96.

i'm idiot.

here we go again. i'm an idiot apperently.

backup for the builder

Update and rename build copy.yml to build2.yml

first tryout

Update build2.yml

rename

Update build2.yml

updated workflow

Update build2.yml

minor change

Update build2.yml

workflow change

Update build2.yml

bugfix workflow

Update build2.yml

workflow test

Update build2.yml

workflow test

Update build2.yml

workflow test

Update build2.yml

workflow test

Update build2.yml

kibot should use the right config

Update zswatch.kibot.yaml

added subdirectory.

Update build2.yml

removed whitespace

Update build2.yml

removed variants

Update zswatch.kibot.yaml

hopefully set an output dir for each variant

Update zswatch.kibot.yaml

still with the output...

Update zswatch.kibot.yaml

reversed changes

Update build2.yml

reversed changes

Update build2.yml

added again screenshot stuff.

Update build2.yml

fixed artifact upload

Update build2.yml

simplified action

Update zswatch.kibot.yaml

updated kibot.yaml config

Update build2.yml

further simplifcation of workflow

Update build2.yml

test

Update build2.yml

changed kibot.yaml path

Update build2.yml

removed cd into project folder

Update zswatch.kibot.yaml

revert changes

Update build2.yml

Update build.yml

Simplified action to generate files

Delete .github/workflows/build2.yml

removed this file, because it was just for testing

i'm idiot.

here we go again. i'm an idiot apperently.

Add image from CI/CD action

Closes #68

Add image from CI/CD action

Add missing schematics changes for level shifter mirroring
@blubbsy
Copy link
Author

blubbsy commented Sep 30, 2024

my git skills have to seriously improve... still i dont get why it wants to commit again the library path or thinks that it differs, but okay.

blubbsy and others added 3 commits September 30, 2024 20:34
* Added footprints from external library
* Added Project relevant paths
* Added 3D Models from external library
* Changed path of 3D Models to use the prj path.
Copy link
Collaborator

@jakkra jakkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over than that I'll let @Kampi review. But from my side it looks like a great "Cleanup", thanks!

@@ -1,4 +1,4 @@
name: Build
name: Build2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back to just "Build"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah mine error. thanks for correcting it!

@@ -8,7 +8,8 @@ on:

jobs:
build:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, latest is nice, but I'm thinking there is a risk it may break in future. So to be safe I suggest just changing to Ubuntu 24.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use latest. Let's stick to one version, test everything with it and then migrate to a newer version later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. does it make sense to switch to Ubuntu 24.04 as it is the newest LTS version. Apparently with latest it is working at the moment, so there is no need to switch again in the next 5 years.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo we can use the latest LTS if it's working.

@Kampi
Copy link
Collaborator

Kampi commented Oct 17, 2024

Sorry I missed it completely because I removed it from my task list accidentally. I will check it later on my PC.

@Kampi Kampi merged commit b7c6b64 into ZSWatch:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants