Hid the devices serial number by default #1945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the devices serial number should be hidden by default to allow users to prevent the leaking of identifiable information.
As they can choose obscure yet memorable usernames for the accounts of the TOTP authenticators, the only identifiable information that can't be hidden is the devices serial number.
I propose that a gesture detector should be added to the right of the serial number text UI, which toggles the visibility of the serial number when held downa and the serial number label in the device picker be removed.
Here are some screenshots of what I implemented:
Resolves: #1944