Mark all public value types as 'Sendable' #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Sendable conformance to all public value types in the YubiKit framework to improve thread safety in concurrent Swift code. This ensures that these types can be safely passed across concurrency boundaries without data races.
Key changes include:
- Adding Sendable conformance to public enums, structs, and protocols
- Enabling safer concurrent usage of YubiKit types in async/await contexts
- Maintaining backwards compatibility while improving type safety
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Data+Extensions.swift | Adds Sendable to PIVEncryptionError enum |
| Connections.swift | Adds Sendable to WiredConnection and AnyConnection enums |
| SmartCardConnection.swift | Adds Sendable to SmartCardConnectionError enum |
| Session.swift | Adds Sendable to SessionFeature protocol and SessionError enum |
| SecurityDomainSession.swift | Adds Sendable to SCPError enum |
| SCP11KeyParams.swift | Adds Sendable to SCP11KeyParams struct |
| SCP03KeyParams.swift | Adds Sendable to SCP03KeyParams struct |
| Response.swift | Adds Sendable to Response struct |
| PIVSessionFeature.swift | Adds Sendable to PIVSessionFeature enum |
| PIVPadding.swift | Adds Sendable to PIVPaddingError enum |
| PIVDataTypes.swift | Adds Sendable to multiple PIV-related types and enums |
| OATHSessionFeature.swift | Adds Sendable to OATHSessionFeature enum |
| OATHSession.swift | Adds Sendable to OATHSessionError and DeriveAccessKeyError |
| OATHSession+Extensions.swift | Adds Sendable to CredentialTemplateError and CredentialTemplate |
| NFCConnection.swift | Adds Sendable to NFCConnectionError enum |
| ManagementSession.swift | Adds Sendable to ManagementSessionError enum |
| ManagementFeature.swift | Adds Sendable to ManagementFeature enum |
| DeviceInfo.swift | Adds Sendable to DeviceTransport, FormFactor enums and DeviceInfo struct |
| DeviceConfig.swift | Adds Sendable to DeviceConfig struct |
| Capability.swift | Adds Sendable to Capability enum |
| RSAKeys.swift | Adds Sendable to RSA enum |
| Keys.swift | Adds Sendable to CryptoKeyKind, PublicKey, and PrivateKey enums |
| ECKeys.swift | Adds Sendable to EC enum |
| Connection.swift | Adds Sendable to ConnectionError enum and ResponseError struct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for the callers of this SDK to be able send these types across actor boundaries.
These annotations fix a bunch of warnings in our sample apps.
All these types are pure value types and have all reasons to be marked as Sendable.