Ykmd 5.0 SCP11b/MSVC updates #557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use bcrypt pseudohandles for Win7 compat
Improve ecdh provider handle management Allow direct scp11 session call from ykmd
Add conditions of use error for commands that require scp session
Fix tool build include of bcrypt.h
Fix x86 build ref to htonl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have ported the ECDH CNG functions to be Win8 compatible (earlier CNG implementations do not support pseudo-handles). Also, a lot of MSVC specific warnings have been mitigated in libykpiv for a clean build in the tool and minidriver build.
The scp11_open_channel function has been made internal public to the minidriver, to deterministically establish an scp connection, since it cannot use the standard ykpiv_connect function.
I also found a logic error in the size check for scp11b messages, which has been fixed.