-
Notifications
You must be signed in to change notification settings - Fork 159
Add support for credProtect extension #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results2 251 tests 2 243 ✅ 58s ⏱️ Results for commit 613d34f. ♻️ This comment has been updated with latest results. |
webauthn-server-core/src/main/java/com/yubico/webauthn/data/Extensions.java
Outdated
Show resolved
Hide resolved
We did not expect this go from us asking about it on a random Thursday to seeing a PR merged in such a short time. Thank you so much! |
@ethantmcgee Sorry for the delay, but this is now available on Maven Central in pre-release |
@emlun thanks so much for adding this, we were able to put this into the project today and test. It doesn't appear the generated json is correct. When I setup the options that we want via
which seems to line up with the mozilla documentation. The webauthn library is instead generating
We are configuring the extensions as follows: var extensions = RegistrationExtensionInputs.builder()
.credProps()
.credProtect(Extensions.CredentialProtection.CredentialProtectionInput.require(UV_REQUIRED)); Please let me know if I've done something incorrectly and thanks again! |
Well that's embarrassing 😆 good catch, thanks! |
This should be fixed in |
We look forward to the release. |
See: https://fidoalliance.org/specs/fido-v2.1-ps-20210615/fido-client-to-authenticator-protocol-v2.1-ps-20210615.html#sctn-credProtect-extension