Skip to content

Revert new experimental interfaces and classes #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -29,37 +29,6 @@ New features:
instead of an ordinary WebAuthn response. See the JavaDoc for details.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
* (Experimental) Added a new suite of interfaces, starting with
`CredentialRepositoryV2`. `RelyingParty` can now be configured with a
`CredentialRepositoryV2` instance instead of a `CredentialRepository`
instance. This changes the result of the `RelyingParty` builder to
`RelyingPartyV2`. `CredentialRepositoryV2` and `RelyingPartyV2` enable a suite
of new features:
** `CredentialRepositoryV2` does not assume that the application has usernames,
instead username support is modular. In addition to the
`CredentialRepositoryV2`, `RelyingPartyV2` can be optionally configured with
a `UsernameRepository` as well. If a `UsernameRepository` is not set, then
`RelyingPartyV2.startAssertion(StartAssertionOptions)` will fail at runtime
if `StartAssertionOptions.username` is set.
** `CredentialRepositoryV2` uses a new interface `CredentialRecord` to
represent registered credentials, instead of the concrete
`RegisteredCredential` class (although `RegisteredCredential` also
implements `CredentialRecord`). This provides implementations greater
flexibility while also automating the type conversion to
`PublicKeyCredentialDescriptor` needed in `startRegistration()` and
`startAssertion()`.
** `RelyingPartyV2.finishAssertion()` returns a new type `AssertionResultV2`
with a new method `getCredential()`, which returns the `CredentialRecord`
that was verified. The return type of `getCredential()` is generic and
preserves the concrete type of `CredentialRecord` returned by the
`CredentialRepositoryV2` implementation.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
* (Experimental) Added property `RegisteredCredential.transports`.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
** NOTE: Experimental features may receive breaking changes without a major
version increase.

`webauthn-server-attestation`:

Expand Down

This file was deleted.

Loading
Loading