-
Notifications
You must be signed in to change notification settings - Fork 60
build: Update .NET Framework target to 4.7.2 #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Results: Windows 2 files 2 suites 10s ⏱️ Results for commit f83605a. ♻️ This comment has been updated with latest results. |
Test Results: Ubuntu 2 files 2 suites 20s ⏱️ Results for commit f83605a. ♻️ This comment has been updated with latest results. |
Test Results: MacOS 2 files 2 suites 11s ⏱️ Results for commit f83605a. ♻️ This comment has been updated with latest results. |
7f4f6e2
to
c4e6bda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the .NET Framework target to 4.7.2 and upgrades several package dependencies across projects for improved API support, performance, and security fixes.
- Change target frameworks from
net47
tonet472
in project and nuspec files. - Bump key package references (e.g., Microsoft.Extensions.*) to version
9.0.6
. - Adjust file paths in the NativeShims nuspec to match the new framework.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
Yubico.YubiKey/src/Yubico.YubiKey.csproj | Updated net47 to net472 and bumped package versions for AsyncInterfaces, Logging.Abstractions, and Cbor. Adjusted HttpUtility item group. |
Yubico.NativeShims/Yubico.NativeShims.nuspec | Changed targetFramework group to .NETFramework4.7.2 and updated build/lib paths to net472 . |
Yubico.Core/src/Yubico.Core.csproj | Updated net47 to net472 and bumped Configuration.Json, Logging.Abstractions, and Options.ConfigurationExtensions versions. |
Comments suppressed due to low confidence (1)
Yubico.YubiKey/src/Yubico.YubiKey.csproj:133
- [nitpick] Update the comment to use consistent casing (e.g.,
.NET472
or.NET Framework 4.7.2
) for clarity.
<!-- This is in order to use the HttpUtility.ParseQueryString in .net472 -->
This PR replaces #271 |
Co-authored-by: Copilot <[email protected]>
@DennisDyallo : Any idea on when this change will be merged? |
Hi @AlexLaroche . Sorry for the late response. Is this PR meaningful to you in any particular way? If so, please share. |
@DennisDyallo : Same goal as what was pursued by: #267 Fix a vulnerability reported in System.Private.Uri (version 4.3.0) which is a transitive dependency of the 'System.Runtime.InteropServices.RuntimeInformation' library (version 4.3.0). |
Our next release is planned for September 17th @AlexLaroche Can you stick it out until then? |
This PR replaces #271
Opting for even broader compatibility over the Net48 update for now.
This pull request updates the project to target .NET Framework 472 and upgrades several dependencies to their latest versions. It includes changes to project files, source code, and build configurations to reflect this update.
Updating addresses performance, greater API and Netstandard 2.0 support, as well as upgrades addresses vulnerabilities (CVE-2019-0981: Denial of Service in System.Private.Uri) (fixed in NET472)
These are in place upgrades that most machines should have by now.
NET 472 is included on Windows Server 2019 (WS2019 is EOL by Msft) and most users will have it installed already.
Based on researching the compatibility of different .NET targetFramework versions and Windows and Windows server, I recommend upgrading to NET472 to enable the performance improvements, vulnerability patches and API features. This version allows us to upgrade and ensures the broadest compatibility.
Below are the changes for each of these version updates:
.NET Framework 4.7.1
Full changelog
.NET Framework 4.7.2
Full changelog
Framework Updates:
net47
tonet472
inTargetFrameworks
forYubico.Core.csproj
,Yubico.YubiKey.csproj
, andYubico.NativeShims.nuspec
. This ensures compatibility with newer features and improvements provided by.NET Framework 4.7.2
. [1] [2] [3]Package Dependency Updates:
Microsoft.Extensions.Configuration.Json
,Microsoft.Extensions.Logging.Abstractions
, andMicrosoft.Extensions.Options.ConfigurationExtensions
to version9.0.6
inYubico.Core.csproj
. This improves library compatibility and adds new features.Microsoft.Bcl.AsyncInterfaces
,Microsoft.Extensions.Logging.Abstractions
, andSystem.Formats.Cbor
to their latest versions inYubico.YubiKey.csproj
. This ensures better performance and compatibility with modern standards. [1] [2]File Path Adjustments:
Yubico.NativeShims.nuspec
to reflect the updated target framework (net472
). This aligns the build and runtime files with the new framework version.