feat: Add FirmwareVersion.Parse(versionString)

Yubico.YubiKey/src/Yubico/YubiKey/FirmwareVersion.cs

@@ -61,6 +61,36 @@ public FirmwareVersion(byte major, byte minor = 0, byte patch = 0)
             Minor = minor;
             Patch = patch;
         }
+
+        /// <summary>
+        /// Parse a string of the form "major.minor.patch"
+        /// </summary>
+        /// <param name="versionString"></param>
+        /// <returns>Returns a FirmwareVersion instance</returns>
+        /// <exception cref="ArgumentNullException"></exception>
+        /// <exception cref="ArgumentException"></exception>
+        public static FirmwareVersion Parse(string versionString)
+        {
+            if (versionString is null)
+            {
+                throw new ArgumentNullException(nameof(versionString));
+            }
+
+            string[] parts = versionString.Split('.');
+            if (parts.Length != 3)
+            {
+                throw new ArgumentException("Must include major.minor.patch", nameof(versionString));
+            }
+
+            if (!byte.TryParse(parts[0], out byte major) ||
+                !byte.TryParse(parts[1], out byte minor) || 
+                !byte.TryParse(parts[2], out byte patch))
+            {
+                throw new ArgumentException("Major, minor and patch must be valid numbers", nameof(versionString));
+            }
+
+            return new FirmwareVersion(major, minor, patch);
+        }
 
         public static bool operator >(FirmwareVersion left, FirmwareVersion right)
         {

Yubico.YubiKey/tests/unit/Yubico/YubiKey/FirmwareVersionTests.cs

@@ -20,6 +20,38 @@ namespace Yubico.YubiKey
 {
     public class FirmwareVersionTests
     {
+        [Fact]
+        public void Parse_GivenValidString_ReturnsFirmwareVersion()
+        {
+            // Arrange
+
+            string validString = "1.2.3";
+
+            // Act
+
+            var fw = FirmwareVersion.Parse(validString);
+
+            // Assert
+
+            Assert.Equal(1, fw.Major);
+            Assert.Equal(2, fw.Minor);
+            Assert.Equal(3, fw.Patch);
+        }
+
+
+        [Fact]
+        public void Parse_GivenInvalidString_ThrowsArgumentException()
+        {
+            // Arrange
+
+            string invalidString = "1.2";
+
+            // Act & Assert
+
+            Assert.Throws<ArgumentException>(() => FirmwareVersion.Parse(invalidString));
+        }
+
+
         [Fact]
         public void Major_GetSet_Succeeds()
         {