-
Notifications
You must be signed in to change notification settings - Fork 72
Please use a crc library that provides a pure Python implementation #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any suggestions for such a library? |
It's only used here so the change should be simple. Line 5 in fedab4c
I'm guessing we'll need these parameters, that's the main tricky part Actually, these are the current parameters: |
>>> import crcmod.predefined
>>> crc16 = crcmod.predefined.mkPredefinedCrcFun('crc-16')
>>> crc16(b"abcd")
14743
>>> calc = crc.Calculator(crc.Configuration(width=16, polynomial=0x8005, reverse_input=True, reverse_output=True))
>>> calc.checksum(b"abcd")
14743 |
pepijndevos
added a commit
that referenced
this issue
Jan 20, 2024
Fixed #217 and hopefully makes peoply trying to to bundle/install Apicual in weird ways a little happier for having to compile less C.
Merged
pepijndevos
added a commit
that referenced
this issue
Jan 20, 2024
* Switch crcmod to crc Fixed #217 and hopefully makes peoply trying to to bundle/install Apicual in weird ways a little happier for having to compile less C. * the stupid thing isn't thread safe * python scoping rules are dumb
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, Apycula cannot be used with Pyodide:
This is the only problematic dependency AFAICT (numpy is supported).
The text was updated successfully, but these errors were encountered: