forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 63
support both input and data in eth_call, eth_estimateGas, personal_sendTransaction #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gzliudan
merged 3 commits into
XinFinOrg:dev-upgrade
from
JukLee0ira:api-tx-args-update
Aug 21, 2024
Merged
support both input and data in eth_call, eth_estimateGas, personal_sendTransaction #597
gzliudan
merged 3 commits into
XinFinOrg:dev-upgrade
from
JukLee0ira:api-tx-args-update
Aug 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c98403
to
b340fe9
Compare
JukLee0ira
commented
Aug 1, 2024
b340fe9
to
b58d1a7
Compare
Please use code format for request and json format for response, such as: ```shell // request code ``` ```json // response text ``` |
gzliudan
requested changes
Aug 2, 2024
c9c5d18
to
fbb6014
Compare
gzliudan
requested changes
Aug 5, 2024
7596f66
to
7c4165a
Compare
gzliudan
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wjrjerome
approved these changes
Aug 7, 2024
f05af0f
to
64ae8a3
Compare
64ae8a3
to
67ec164
Compare
gzliudan
approved these changes
Aug 14, 2024
liam-lai
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A user reported a bug in here when using the Go-Ethereum client to call JSON-RPC. The issue arises because the parameter field 'data' has been renamed to 'input' from version 1.13 onwards.
This PR adds support of "input" field in
eth_call
,eth_estimateGas
. Field "data" will be still supportedTest
When this PR is not merged:
eth_call
data
fieldRequest:
Response:
input
fieldRequest:
Response:
Request:
Response:
input
field and adata
field, and these fields have the same value.Request:
Response:
input
field and adata
field, but these fields have different values.Request:
Response:
eth_estimateGas
data
fieldRequest:
Response:
input
fieldRequest:
Response:
Request:
Response:
input
field and adata
field, and these fields have the same value.Request:
Response:
input
field and adata
field, but these fields have different values.Request:
Response:
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that