PDLL: Add equals operator #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsan-toosi
reviewed
Feb 27, 2024
Comment on lines
+43
to
+65
| LogicalResult equals(mlir::PatternRewriter &, mlir::Attribute lhs, | ||
| mlir::Attribute rhs) { | ||
| if (auto lhsAttr = dyn_cast_or_null<IntegerAttr>(lhs)) { | ||
| auto rhsAttr = dyn_cast_or_null<IntegerAttr>(rhs); | ||
| if (!rhsAttr || lhsAttr.getType() != rhsAttr.getType()) | ||
| return failure(); | ||
|
|
||
| APInt lhsVal = lhsAttr.getValue(); | ||
| APInt rhsVal = rhsAttr.getValue(); | ||
| return success(lhsVal.eq(rhsVal)); | ||
| } | ||
|
|
||
| if (auto lhsAttr = dyn_cast_or_null<FloatAttr>(lhs)) { | ||
| auto rhsAttr = dyn_cast_or_null<FloatAttr>(rhs); | ||
| if (!rhsAttr || lhsAttr.getType() != rhsAttr.getType()) | ||
| return failure(); | ||
|
|
||
| APFloat lhsVal = lhsAttr.getValue(); | ||
| APFloat rhsVal = rhsAttr.getValue(); | ||
| return success(lhsVal.compare(rhsVal) == llvm::APFloatBase::cmpEqual); | ||
| } | ||
| return failure(); | ||
| } |
There was a problem hiding this comment.
Why only IntegerAttr and floatAttr and why don't we use == operator from Attribute class?
mgehre-amd
force-pushed
the
matthias.pdll_neg_precedence
branch
2 times, most recently
from
cc9994e to
0be8938
Compare
Base automatically changed from
matthias.pdll_neg_precedence
to
feature/fused-ops
March 8, 2024 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.