Merge upstream 6 commits #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GameVersion from IShadow3, lessening usage of fake gameversion IDs fix sav3 with absurdly high record values (int.MaxValue -> uint.MaxValue)
PLA sneasel -> transfer, catch virus -> PLA, evolve => was flagged. Need to check the encounter species-form, not the current species-form. List all the species-form that are of consideration. Wyrdeer, Kleavor, Ursaluna, Sneasler, Overqwil, Basculegion
projectpokemon/PoGoEncTool@f2296cc update pickles because Necrozma encounter types had to be incremented by one
|
Caution Review failedThe pull request is closed. WalkthroughThe recent changes enhance the functionality and flexibility of the PKHeX project, particularly focusing on the Pokérus mechanics, encounter data handling, and user interface improvements. Key modifications include the integration of encounter-related parameters in various methods, new event entries, and updates to the Pokémon type enumerations. Additionally, minor refinements in code readability and user experience have been implemented across different components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Pokerus
participant Encounter
User->>Pokerus: Call IsObtainable(PKM, ISpeciesForm)
Pokerus->>Encounter: Check encounter data
Encounter-->>Pokerus: Return encounter status
Pokerus-->>User: Return Pokérus obtainability
sequenceDiagram
participant User
participant MiscVerifier
User->>MiscVerifier: Call VerifyMiscPokerus(PKM)
MiscVerifier->>Encounter: Retrieve encounter data
Encounter-->>MiscVerifier: Return data
MiscVerifier-->>User: Return validity of Pokérus strain
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge 6 commits including stenee, sylveon , go research timed for Worlds
Summary by CodeRabbit
New Features
Research10enumeration value for Pokémon captured after completing Field Research.Bug Fixes
User Experience Improvements
Refactor