Merge latest releast into dev build #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not something worth retaining if we can check directly.
Handles Nidoran's shenanigans as well as more clear method names - Add normalization for PK7->PK8 (no more 0xE... usage for the gender symbols... maybe more chars?) - Not sure if Gen3 gamecube encoding needs sanitizing. Who is transferring Nidoran to CXD? :) Requires some silly usage of Language passing as arguments. Future improvements can be made to revise the half/full encoding determination when setting a string. Probably has issues since we're just doing a naive check without considering nicknames w/ special chars. Closes #4174
Legality check now catches buffer overflow mons. Now that I have each type exposing a trash length & charcount, should be easy to have some reusable trash byte measuring methods (see the old branch)
* Update LegalityCheckStrings_ja.txt * Update lang_ja.txt * Update lang_ja.txt * Update MessageStrings_ja.txt * Update const_hgss_ja.txt * Update const_rs_ja.txt * Update const_e_ja.txt * Update text_ItemsG3_ja.txt * Update text_ItemsG2_ja.txt * Update text_ItemsG1_ja.txt * Update text_Character_ja.txt * Update lang_ja.txt * Update lang_ja.txt * Update lang_ja.txt * Update MessageStrings_ja.txt * Update LegalityCheckStrings_ja.txt * Update flags_dp_ja.txt * Update flags_pt_ja.txt
Closes #4227 SlotWrite no longer revises the data incorrectly if ot&gender mismatch, clear memories and set new values can retain wrong values by having ot&gender shared between games
Maybe only a GSC thing where Stadium 2 doesn't know better?
* Update EncounterServerDate.cs * Add files via upload
The handler state checks to check against current trainer are new, forgot about this edge case. Reduce allocation of temp strings on wc7->pk7, replicate the HT miss for ash pika wc7->pk7
No longer need to disable correct-handler-state check for unit tests Adds indication for HT not matching gender (if active trainer is set)
If the boxes are not initialized, skip reading of box data
If the boxes are empty when saving, don't write if {dest 0} or {boxes uninitialized} to retain old data.
If the boxes have any slots when saving, set the flag that boxdata is good.
Remove flag from SAV2, game is different from SAV1. Only use the boxdata, just mirror to CurrentBox data as Stadium only looks at boxdata.
Read count from list, instead of using the full capacity. Malformed lists (truncated via count) with ghost slots should have those ghost slots ignored.
Adding an entity to an uninitialized save's box data will force all data to be flushed unless the final destination was (initially zeroed and has no slots to set).
Deleting a slot shouldn't leave a level 0 nameless speciesless mon
Extract result valid check to less-wide style, add extra sanity checks for Gen3 typed saves.
No need to clone the save file and allocate 2 bool arrays. Yay old code, why not do it better now? :)
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 91 files out of 149 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.