Fixed an issue where footnote references were being rendered without brackets #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See this page in the XST docs for an example of references: https://xanadu-sphinx-theme--27.org.readthedocs.build/en/27/gallery/tutorial_demo.html |
Mandrenkov
reviewed
Oct 22, 2022
|
Yep, unfortunately it's a stylistic change that Sphinx made in versions 2.0+. Versions <2.0 render the reference number to the left of the reference text, not above |
Mandrenkov
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This was previously fixed in the QML repo, but the fix must have been accidentally reverted when porting to the Xanadu Sphinx Theme.
Description of the Change: As title.
Benefits: As title.
Possible Drawbacks: n/a
Related GitHub Issues: n/a