Skip to content

Fixes a tiny bug where non-bot commits would return the old format of version for the CHANGELOG bump #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

martellato
Copy link
Collaborator

As of #50 we use SemVer to sort versions instead of string sorting. SemVer does not like leading v which forced us to make some changes in the version function as well. An early return was still using leading_v that caused changelog to fail.

@martellato martellato merged commit 0504013 into main Aug 21, 2023
@martellato martellato deleted the fix-non-bot-commit-return branch August 21, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants