-
Notifications
You must be signed in to change notification settings - Fork 2
generate-docker-image-tags
supports release
triggers
#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate-docker-image-tags
supports release
triggers
#18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! 🧙
Do you have a link to a GitHub Actions run which uses this version of the GDIT action? We may need to update the get-tags
step to set PR_NUMBER
to the empty string when the GitHub event trigger is a release.
I have the following tests of this action (which found a bug in how PR_NUMBER is rendered, fix pushed to this branch): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelvu97! Where in those runs do you see the generated tags though?
Co-authored-by: Mikhail Andrenkov <[email protected]>
@Mandrenkov thanks for pointing that out. Here are some more tests with the tags actually printed 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks @michaelvu97! 👍 Just one query before I can Approve in good conscience!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to get to the ❤️ of the problem, @michaelvu97!
Background
GitHub Actions may trigger workflows when a
release
is created.Changes
generate-docker-image-tags
supports being triggered from arelease
workflow context.git tag
to thedocker image tag
Sample Usage in Workflow
E.g. if a release is created from the tag
v1.5.1
, this workflow will output a docker image tag:release.v1.5.1