Skip to content

CPLAT-3300: CP Code Review and PR Merging Team agreement update #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

greglittlefield-wf
Copy link
Contributor

Client Platform is refreshing our contributing instructions as a result of solidifying our internal CP Code Review
and PR Merging Team agreement.

You can view the Details in this RFD: https://docs.google.com/document/d/1zQ9gMMnQo3AyYQfCThCwB76aYpU3BMmqm1faD5EA8bU/edit

This PR aligns the CONTRIBUTING.md and PULL_REQUEST_TEMPLATE.md with the new agreement.

  • Removes all existing potential variations of CONTRIBUTING, PULL_REQUEST_TEMPLATE, and CODEOWNERS.

  • Adds standardized PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@trentgrover-wf trentgrover-wf changed the title AF-3300: CP Code Review and PR Merging Team agreement update CPLAT-3300: CP Code Review and PR Merging Team agreement update Mar 17, 2019
@trentgrover-wf
Copy link
Contributor

+1
docs only change

@Workiva/release-management-pp

@trentgrover-wf
Copy link
Contributor

failing dart 2 build due to analyzer fatal warnings...

@codecov-io
Copy link

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           4        4           
  Lines         348      348           
=======================================
  Hits          336      336           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097fa78...b7cb441. Read the comment docs.

@greglittlefield-wf
Copy link
Contributor Author

+1 @Workiva/release-management-pp

@maxwellpeterson-wf
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants