Skip to content

make activeSpan protected #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2018
Merged

make activeSpan protected #122

merged 1 commit into from
Sep 11, 2018

Conversation

toddbeckman-wf
Copy link
Contributor

@toddbeckman-wf toddbeckman-wf commented Sep 11, 2018

This only limits the public API without affecting functionality.

Testing:

  • CI passes

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files           4        4           
  Lines         413      413           
=======================================
  Hits          389      389           
  Misses         24       24
Impacted Files Coverage Δ
lib/src/lifecycle_module.dart 96.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4a753...951ec86. Read the comment docs.

@greglittlefield-wf
Copy link
Contributor

+10

@toddbeckman-wf
Copy link
Contributor Author

@Workiva/release-management-p

@rm-astro-wf rm-astro-wf merged commit a422884 into master Sep 11, 2018
@rm-astro-wf rm-astro-wf deleted the make_activeSpan_protected branch September 11, 2018 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants