AF-1387 Remove dart:mirrors & SerializableModule

[robbecker-wf]

Overview

Dart 2 removes dart:mirrors support when compiled to JS. So we're removing usage of dart:mirrors
This is a breaking change since it is a removal of multiple publicly exposed classes.

The only affected consumers are updated. (w_viewer and w_viewer_mobile.)
PRs are https://github.com/Workiva/w_viewer/pull/528 and https://github.com/Workiva/w_viewer_mobile/pull/32

Release plan (remove breaking change risk)

• Review, merge, and tag w_viewer major version 9.0.0
• Consume w_viewer 9 in w_viewer_mobile
• Release w_viewer_mobile
• Release mobile apps

Remove dart:mirrors from product lines + unified (unblock dart 2)

• Review, merge this PR
• Tag w_module 2.0
• Consume w_module 2.0 in all tier 1 projects

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on HipChat: InfoSec Forum.

[todbachman-wf]

Why is serializable module being removed? Well, I mean that I see it uses mirrors, but are there no consumers for it at this point? Or do they have an alternative?

[robbecker-wf]

SerializableModule is only used for the mobile viewer https://github.com/search?q=org%3AWorkiva+SerializableModule&type=Code .. I'm spiking out reimplementing that native/dart bridging without reflection in https://github.com/Workiva/w_viewer_mobile/pull/32 and https://github.com/Workiva/w_viewer/pull/528

[codecov-io]

Codecov Report

Merging #113 into master will increase coverage by 2.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   93.49%   96.16%   +2.67%     
==========================================
  Files           4        3       -1     
  Lines         369      287      -82     
==========================================
- Hits          345      276      -69     
+ Misses         24       11      -13

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2976ab...17a5586. Read the comment docs.

[jayudey-wf]

+1

[jayudey-wf]

+10

• code intended to be removed (which constitutes a breaking change, which this has been marked as) was

[maxwellpeterson-wf]

QA +1

• Dev +1's
• Dev/QA +10 with detail of what was tested
  • AF-1387 Remove dart:mirrors & SerializableModule #113 (comment)
• Tests created/updated
  • code removal only
• All tests pass

@Workiva/release-management-pp

[robbecker-wf]

+1 on Max's commits