chore: Refactor Select Input to a single Stencil #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
changed the title
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-refactor-select-stencil
|
| Run status |
|
| Run duration | 02m 56s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
936
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.27%
|
|
|---|---|
|
Untested elements
|
1530
|
|
Tested elements
|
411
|
Accessibility
99.28%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
98
|
|
closing. this doesn't solve the problem just quite. |
| maxHeight: px2rem(300), | ||
| export const selectCardStencil = createStencil({ | ||
| base: { | ||
| maxHeight: px2rem(300), |
There was a problem hiding this comment.
It seems like maxHeight should be a Stencil variable in MenuCard since menu cards often need some type of overflow height. We don't want them to be too large. There should be some default. I don't want the CSS variable to be passed via JavaScript because that would restrict overrides via CSS.
It would looks something like:
base: {
[menuCardStencil.vars.maxHeight]: px2rem(300),
]I don't know if menuCard should have a default maxHeight... It seems like it should. Menus aren't always popups, but a MenuCard is always part of a popup.
There was a problem hiding this comment.
give it another look when you get a second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
Select.Inputto use a single stencil using thepartsproperty oncreateStencil.Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)