Skip to content

Allow network admins to manage application passwords for all users #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Allow network admins to manage application passwords for all users #8638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d4cc2
Allow network admins to manage application passwords for all users
Sukhendu2002 Apr 2, 2025
674a0f8
Add multisite check in test_create_item_for_user_without_role_on_main…
Sukhendu2002 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/rest-api/endpoints/class-wp-rest-application-passwords-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ protected function get_user( $request ) {
return $error;
}

if ( is_multisite() && ! user_can( $user->ID, 'manage_sites' ) && ! is_user_member_of_blog( $user->ID ) ) {
if ( is_multisite() && ! current_user_can( 'manage_network_users' ) && ! user_can( $user->ID, 'manage_sites' ) && ! is_user_member_of_blog( $user->ID ) ) {
return $error;
}

Expand Down
28 changes: 28 additions & 0 deletions tests/phpunit/tests/rest-api/rest-application-passwords-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,4 +1069,32 @@ private function setup_app_password_authenticated_request() {

return $item;
}

/**
* @ticket 60029
* @group ms-required
*/
public function test_create_item_for_user_without_role_on_main_site() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are interesting but the only question that comes to my mind is that I can't see with these tests is that the actual method WP_REST_Application_Passwords_Controller::get_user that is causing the issue is not being asserted. So the test is failing because of an error, not because of a wrong assert.

wp_set_current_user( self::$admin );

$blog_id = self::factory()->blog->create();
$user_id = self::factory()->user->create();

// Remove user from main site if they were automatically added.
if ( is_user_member_of_blog( $user_id ) ) {
remove_user_from_blog( $user_id, get_current_blog_id() );
}
add_user_to_blog( $blog_id, $user_id, 'subscriber' );

$this->assertFalse( is_user_member_of_blog( $user_id ) );

$request = new WP_REST_Request( 'POST', sprintf( '/wp/v2/users/%d/application-passwords', $user_id ) );
$request->set_body_params( array( 'name' => 'Test App' ) );
$response = rest_do_request( $request );
$this->assertSame( 201, $response->get_status() );

$passwords = WP_Application_Passwords::get_user_application_passwords( $user_id );
$this->assertCount( 1, $passwords );
$this->assertSame( 'Test App', $passwords[0]['name'] );
}
}
Loading