-
Notifications
You must be signed in to change notification settings - Fork 2.9k
CSS: Remove unnecessary opacity for Firefox placeholders. #8425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @mleray. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the theme files unchanged in this pull request. WordPress (administration) limits its browser support to the latest versions of Firefox, but the themes could retain more support for older browsers.
Also, I think the :-ms-input-placeholder
rulesets can be removed from the color-picker
, forms
and media-views
stylesheets at this time. I'll mention that in the ticket for more discussion.
Thanks for the review @sabernhardt, I have removed the |
d55c43e
to
8d3574f
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/63030
This PR removes unnecessary
opacity: 1
rules for::-moz-placeholder
selectors in Core and bundled themes. Firefox changed its placeholder implementation from opacity-based to using color-mix, making these overrides redundant while maintaining color declarations for accessibility.