Skip to content

Fix RTL display in Optional grouping on Permalinks Settings page #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from

Conversation

sabernhardt
Copy link

@sabernhardt sabernhardt commented Jul 7, 2022

In the main site of subdirectory network installations, the blog prefix does not display correctly in RTL.

LTR (at 820 pixels wide and at 600):

blog prefix in English

smaller screen, in English

In RTL, the slash displays on the wrong side of "blog" and the prefix appears on the wrong side of the input field. Plus, the example URL can wrap awkwardly to the next line.

blog prefix in Arabic

smaller screen, in Arabic

This wraps the prefix and field in a span with the code class and adds CSS to keep the prefix next to the field on smaller screens. In the paragraph, code elements are set to inline-block to keep them on one line (or wrap better).

I also wrapped the Optional group in a fieldset and added aria-describedby to use the paragraph as context to fill out this group of fields. This required a few CSS adjustments for margin and padding.

Trac ticket: https://core.trac.wordpress.org/ticket/58722


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@sabernhardt

This comment was marked as outdated.

@sabernhardt
Copy link
Author

Updated screenshots after removing the fieldset and legend

LTR with patch

with patch, 820 pixels wide, in English

with patch, 600 pixels wide, in English

RTL with patch

with patch, 820 pixels wide, in Arabic

on smaller screen, prefix stays beside input, in Arabic

@sabernhardt
Copy link
Author

This has its own separate ticket 58722 now.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt
Copy link
Author

I added nowrap to avoid breaking the prefix on two lines in Firefox. Also, the condition did not need to use the empty() function when $blog_prefix can only be either /blog or an empty string.

Having the prefix on the left can make the input field a bit smaller. However, it should be enough, even on 320-pixel screens (where the field is about 248 pixels wide, and can show 24 characters before scrolling).

LTR with prefix on left

RTL with prefix on left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant