-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix RTL display in Optional grouping on Permalinks Settings page #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
The paragraph helps fill these fields better than the blog prefix.
Keep example URL and other code snippets from splitting awkwardly onto the next line
This comment was marked as outdated.
This comment was marked as outdated.
...to group them with other styles for the page
The empty $blog_prefix is more common, so that condition is first
This has its own separate ticket 58722 now. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I added Having the prefix on the left can make the input field a bit smaller. However, it should be enough, even on 320-pixel screens (where the field is about 248 pixels wide, and can show 24 characters before scrolling). |
In the main site of subdirectory network installations, the blog prefix does not display correctly in RTL.
LTR (at 820 pixels wide and at 600):
In RTL, the slash displays on the wrong side of "blog" and the prefix appears on the wrong side of the input field. Plus, the example URL can wrap awkwardly to the next line.
This wraps the prefix and field in a span with the
code
class and adds CSS to keep the prefix next to the field on smaller screens. In the paragraph,code
elements are set toinline-block
to keep them on one line (or wrap better).I also wrapped the Optional group in a fieldset and addedaria-describedby
to use the paragraph as context to fill out this group of fields. This required a few CSS adjustments for margin and padding.Trac ticket: https://core.trac.wordpress.org/ticket/58722
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.