Move and update ButtonBlockAppender styles into component stylesheet + improvements #70472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #70179. Improves appender appearance at various layout configuartions.
Why?
Several issues with CSS related to the ButtonBlockAppender component including:
How?
Relocated all styles for ButtonBlockAppender out of the group block’s CSS and into the component’s own stylesheet. Updated the CSS to ensure the appender elements appear where a block's content would appear, and extend layout.js to emit the new class names required by those styles. Addressed drag-over and click state issues. Cleaned up unused CSS related to the component.
layout.js already emits classes that indicate horizontal flex alignment (justification), but does not emit anything for vertical flex alignment. The CSS fix in this PR requires a class that indicates if a block has vertical alignment stretched (is-vertical-alignment-stretch).
Testing Instructions
Play with empty group block or a block that supports inner blocks and layout and uses ButtonBlockAppender. Test switching layouts and setting min-height to see how styles adapt. Test how styles appear on column block.
Screenshots or screencast
Flex layout improvement
Before
appender-fix-before.mp4
After
appender-fix-after.mp4
Drag-over fix
Before
drag-over-before.mp4
After
drag-over-after.mp4
Click state fix
Before
After