TypeScript: migrate dom-ready package to TS #70467
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #67691
Migrating the dom-ready package to TypeScript.
Why?
To enhance DX and add type safety.
How?
By porting the code and tests to TypeScript, inlining the
() => void
callback type and removing the obsolete@typedef Callback
.Since Doctrine was removed from
docgen
in PR #28615, the tooling now understands inline function types. This completes the original TODO to drop theCallback
typedef and use() => void
directly in JSDoc and signatures.Testing Instructions
Typecheck and unit tests.