Skip to content

Docs: Remove misleading section from curating the editor experience #70262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

Mamaduka
Copy link
Member

What?

Closes #63822.

PR removes the misleading "Disable access to the Template Editor" section from curating the editor experience documentation page.

Why?

Removing theme support for block-templates entirely disables block templates for a theme, including rendering them on the frontend. The theme support flags shouldn't be used to restrict access to certain editor features.

Testing Instructions

None.

@Mamaduka Mamaduka self-assigned this May 29, 2025
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner May 29, 2025 12:29
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label May 29, 2025
@Mamaduka Mamaduka requested review from Soean and carolinan May 29, 2025 12:29
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the way it is written there today is very misleading.

I do think there is value in removing this theme support in classic themes which is why it was added. But that isn't clear from the section.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: andreawetzel <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

I do think there is value in removing this theme support in classic themes which is why it was added. But that isn't clear from the section.

Right, it's not related to curating the editor experience. It's more of a theme configuration when a classic theme wants to use the theme.json, but opts out of the block templates support.

The theme handbook might be a better place to document this.

@Mamaduka Mamaduka merged commit 9155bcd into trunk May 29, 2025
69 of 70 checks passed
@Mamaduka Mamaduka deleted the docs/remove-misleading-curating-section branch May 29, 2025 13:05
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 29, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ordPress#70262)

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: andreawetzel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding remove_theme_support( 'block-templates' ) for site with existing user created template causes error
2 participants