Skip to content

File Block: Refactor setting panel to use ToolsPanel #70189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shimotmk
Copy link
Contributor

What?

Part of #67813

Make the settings panel more consistent with other blocks

Testing Instructions

  1. Open a post or page.
  2. Insert a file block
  3. Open the settings panel
  4. You can see that you can set it up just like before.

Testing Instructions for Keyboard

Screenshots or screencast

Before After
before-1 before-2 after-2 after-1

Copy link

github-actions bot commented May 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] File Affects the File Block labels May 23, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note: This PR is the same as #69835 and has already been reviewed there.

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 23, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 23, 2025
@t-hamano t-hamano merged commit 16fe235 into WordPress:trunk May 23, 2025
80 of 83 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 23, 2025
@shimotmk shimotmk deleted the enhancement/refactor-file-block-inspector-control-panel branch May 23, 2025 11:25
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of File block to use ToolsPanel instead of PanelBody
3 participants