-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add Image Prefetching for Click to expand Images #61107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Takshil-Kunadia
wants to merge
18
commits into
WordPress:trunk
Choose a base branch
from
Takshil-Kunadia:feature/prefetch-lightbox-images
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−5
Open
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d8e6f5e
Add image prefetching for lightbox images
Takshil-Kunadia 6f66cb1
Fix PHPUnit test
Takshil-Kunadia e345cc6
feat: add delay before prefetching
Takshil-Kunadia 78f0f64
docs: update docs
Takshil-Kunadia 579d32e
fix: track prefetched images to avoid duplicate markup
Takshil-Kunadia 6c5b0cd
docs: add context comments
Takshil-Kunadia d7f2e41
feat: implement responsive image preloading for lightbox images
Takshil-Kunadia 3ab6bc0
refactor: rectify approach to accurate name
Takshil-Kunadia dd686d5
fix: remove URL validation
Takshil-Kunadia 06e3f74
refactor: relocate srcset assignment for better readability
Takshil-Kunadia 1fa9abe
docs: add context comment
Takshil-Kunadia a9bcf60
refactor: address PR feedback — use Map for preload timers, add prelo…
Takshil-Kunadia af3ca8d
refactor: early return for already fetched images
Takshil-Kunadia cab1562
refactor: streamline state logic
Takshil-Kunadia 4dc208b
Revert "refactor: streamline state logic"
Takshil-Kunadia 9c34388
fix: use dynamic lightboxSizes for imagesizes
Takshil-Kunadia 8185a6c
refactor: use separate fns to extract common logic
Takshil-Kunadia b228d53
refactor: destructure image metadata parameter
Takshil-Kunadia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.