Skip to content

Twilight - new dark theme #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Twilight - new dark theme #2694

merged 3 commits into from
Mar 25, 2025

Conversation

dcog989
Copy link
Contributor

@dcog989 dcog989 commented Mar 25, 2025

No description provided.

@dcog989
Copy link
Contributor Author

dcog989 commented Mar 25, 2025

@sdottaka - if you can help fill in any of the ?????? in comments, I will update the source so that it is fully commented and makes a good template for others.

Rearrange and rewrite some of the README for logic / clarity. Add theming section.
@sdottaka sdottaka merged commit 10a6c0e into WinMerge:master Mar 25, 2025
3 checks passed
@sdottaka
Copy link
Member

Thank you!
This PR has been merged.
I will fix the ??? part later. (If the English is wrong in the ??? part, I would appreciate it if you could make another PR.)
The Custom Colors is the part shown in the attached image, so I think you probably defined it. Therefore, I don't know the name.
image

Also, comments in INI files cannot be written at the end of the line. Comments are considered to be values. (This INI file worked because all the values ​​were integers. If the values ​​were strings, the comments would be considered to be values.)
For this reason, I will move the comments at the end of the lines to the beginning of the lines later.

@sdottaka sdottaka added this to the v2.16.47 milestone Mar 25, 2025
@dcog989
Copy link
Contributor Author

dcog989 commented Mar 25, 2025

Thank you!

I will check any updates for grammar, etc and raise new PR as necessary.

I see. So the Custom Colors are not used by the theme? They simply show what is in the color picker? Then the Custom Colors/0, etc could be deleted from the theme?

Thanks for fixing the comments.

P.S. I just noticed I left #7e4242 in comments - that can be deleted if you are moving comments.

sdottaka added a commit that referenced this pull request Mar 26, 2025
@sdottaka
Copy link
Member

sdottaka commented Mar 26, 2025

I see. So the Custom Colors are not used by the theme? They simply show what is in the color picker? Then the Custom Colors/0, etc could be deleted from the theme?

They are not used and can be deleted.

I have committed the corrections, including comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants