This repository was archived by the owner on May 11, 2025. It is now read-only.
Add bottle name validation #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. One suggestion is that you move the warning text to the bottom left of the dialogue instead of underneath the text input so that the input boxes themselves don't get moved |
Marsgames
approved these changes
Jun 11, 2023
rhysm94
suggested changes
Jun 11, 2023
IsaacMarovitz
approved these changes
Jun 12, 2023
ohaiibuzzle
pushed a commit
to ohaiibuzzle/Whisky
that referenced
this pull request
Jun 20, 2023
* Add bottle name validation * Change view to original size * Fix line length violation * Replace NSLocalizedString usage * Change warning text position * Invert name validation logic * Rewrite return message, as enum flags * Update Localizable.strings --------- Co-authored-by: Isaac Marovitz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are no Bottle name checks during the creation and renaming. So, now it's possible to create a bottle without a name, which then uses then uses the
Bottlesdir as its destination, or create/rename to a name that already exists. I've added a check for the name validity, and a warning label.Screen.Recording.2023-06-11.at.17.07.57.mov