Skip to content

Limit jq usage in cursorrules to non-CI environments #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

khleomix
Copy link
Contributor

Closes

Link to test

Test locally and in your CI environment.

Description

  • This PR updates shell scripts (update-cursorrules.sh and test-update-cursorrules.sh) to limit the use of jq to non-CI environments.
  • When running in CI (CI=true), all jq-dependent logic is skipped and a status message is printed.
  • This prevents CI failures due to missing jq, while retaining full functionality for local development and testing.

AI Assistance

  • 🤖 This project was developed with the help of a LLM/AI such as Cursor, Gemini, etc.

Added to documentation?

  • 📜 README.md
  • 📓 ClickUp
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Run the scripts locally and confirm jq logic executes as expected.
  2. Set CI=true and run the scripts; confirm jq logic is skipped and a message is printed.
  3. Run the scripts in your CI environment and confirm no errors occur due to missing jq.

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Linting: Check that the code passes all linting checks (ShellCheck, etc.).
  • CI Compatibility: Confirm that CI runs do not fail due to missing jq.
  • Local Functionality: Confirm that jq logic still works as expected locally.
  • Documentation: Ensure that any new features or changes are appropriately documented if needed.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix requested a review from lindseywb July 24, 2025 18:01
@khleomix khleomix self-assigned this Jul 24, 2025
Copy link
Contributor

@lindseywb lindseywb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khleomix khleomix merged commit 8d97f14 into main Jul 24, 2025
6 checks passed
@khleomix khleomix deleted the hotfix/posinstall-script-conditional branch July 24, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants