Skip to content

Hotfix/#62 Windows Compatibility #72 Font Generation Logic #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

khleomix
Copy link
Contributor

Closes

N/A

Link to test

Test locally

Description

  • package.json uses Unix-specific commands. #62 Update compatibility with Windows.
  • Custom fonts break new font processing tool #72 Refactor webpack config for consistent font output
    • Fonts are now always copied from assets/fonts/ to build/fonts/ with their subfolder structure preserved.
    • Fonts outside the preset subfolders (body, headline, mono) will retain their directory structure in the build output.
    • Removed redundant font copy logic and simplified MiniCssExtractPlugin filename logic for clarity and maintainability.
  • Ensure all CSS files (including style, editor, and RTL variants) and block styles are output to the correct locations.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

AI Assistance

  • 🤖 This project was developed with the help of a LLM/AI such as Cursor, Gemini, etc.

Added to documentation?

  • 📜 README.md
  • 📓 ClickUp
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Run the build process: npm run build
  2. After the build completes, check the build/fonts directory:
    • Fonts in assets/fonts/body/ should appear in build/fonts/body/
    • Fonts in assets/fonts/headline/ should appear in build/fonts/headline/
    • Fonts in assets/fonts/mono/ should appear in build/fonts/mono/
    • Fonts in any other subfolder or directly under assets/fonts/ should retain their directory structure in build/fonts/ (e.g., assets/fonts/custom/foo.woff2 → build/fonts/custom/foo.woff2)
  3. Also check the build/css directory:
    • Ensure style.css, editor.css, style-rtl.css, and editor-rtl.css are present in build/css/
    • Block styles should be in build/css/blocks/ as expected
  4. Confirm there are no unexpected files or folders in the build/fonts or build/css directories.

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix requested a review from thatmitchcanter July 15, 2025 17:39
@khleomix khleomix self-assigned this Jul 15, 2025
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - thanks @khleomix !

@thatmitchcanter thatmitchcanter merged commit d9b0677 into main Jul 15, 2025
6 checks passed
@thatmitchcanter thatmitchcanter deleted the hotfix/#62-Windows-Compatibility branch July 15, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants