-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/WDSBT v1.3 theme font generator #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: WDSBT-261 WP6.8 Testing and Fixes |
thatmitchcanter
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - thanks @khleomix !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#WDSBT-188
#WDSBT-261
Link to test
Test Locally
Description
This PR adds an automated font management system with purpose-based organization and processing tools to streamline font integration in the WDS BT theme.
Key Features Added:
Technical Implementation:
tools/font-processor.php
with comprehensive font processing capabilitiestools/generate-theme-json.php
to use standardized font slugsinc/setup/font-preload.php
Mobile & Desktop Screenshots/Recordings
WDS-BT-Theme.mp4
AI Assistance
Added to documentation?
Added tests?
Testing Instructions
Font Organization Test:
assets/fonts/
by purpose:headline/
for heading fontsbody/
for body text fontsmono/
for monospace/code fontsFont Processing Test:
build/fonts/
maintaining folder structuretheme.json
is updated with font family definitionsinc/setup/font-preload.php
Font Detection Test:
Theme Integration Test:
var(--wp--preset--font-family--headline)
var(--wp--preset--font-family--body)
var(--wp--preset--font-family--mono)
Debug Information Test:
WP_DEBUG = true
in wp-config.phpCode Quality Test:
Reviewer's Testing Checklist
As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.
Additional Reviewer Notes or Considerations?
Key Benefits of This Implementation:
Testing Focus Areas:
This enhancement significantly improves the developer experience for font management while maintaining backward compatibility and following WordPress coding standards.