Skip to content

Feature/WDSBT-261 WP6.8 fixes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 19, 2025
Merged

Conversation

khleomix
Copy link
Contributor

Closes

#WDSBT-261

Link to test

Test Locally

Description

This PR modernizes the WDS BT theme for WordPress 6.8 compatibility and PHP 8.3 support. The changes include:

  1. Linting Configuration Modernization: Migrated from deprecated .eslintrc.json and .stylelintrc.json to modern eslint.config.js and stylelint.config.js formats
  2. PHP 8.3 Compatibility: Updated PHP_CodeSniffer configuration to test PHP 8.2-8.3 compatibility and removed deprecated sniffs
  3. Code Quality Improvements: Resolved all deprecated functions and configurations, ensuring clean linting output
  4. Feature Removal: Completely removed the sticky post fix on query blocks (inc/hooks/query-block-sticky-override.php)
  5. Documentation Updates: Comprehensive README updates including PHP 8.3 compatibility, modernized linting configurations, and version management documentation
  6. Version Bump: Updated theme version to 1.3.0 to reflect the modernization work

Related Tickets & Documents

Fixes #WDSBT-261

Mobile & Desktop Screenshots/Recordings

🙅 No visual changes - this is a backend modernization and code quality improvement PR. All changes are internal to the theme's development workflow and configuration files.

Added to documentation?

  • 📜 README.md
  • 📓 ClickUp
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Linting Tests: Run npm run lint to verify all linting passes without errors
  2. PHP Compatibility: Run npm run lint:php to confirm PHP 8.3 compatibility
  3. Build Process: Run npm run build to ensure the theme builds successfully
  4. Version Management: Test the version update process:
    • Update .env file: echo "VERSION=1.4.0" > .env
    • Run version update: npm run version-update
    • Verify all files are updated correctly
  5. WordPress Integration: Activate the theme in WordPress 6.8+ and verify no errors
  6. Query Blocks: Test that query blocks work normally without the removed sticky post fix

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

Key Changes Summary:

  • All linting configurations modernized and working
  • PHP 8.3 compatibility confirmed
  • No deprecated code or configurations remain
  • Version management workflow documented
  • Theme builds successfully without the removed sticky post functionality

Files of Note:

  • phpcs.xml.dist - Updated for PHP 8.3 compatibility
  • stylelint.config.js - New modern configuration
  • .eslintrc.json - Restored for WordPress compatibility
  • README.md - Comprehensive documentation updates
  • .env - Added for version management

Breaking Changes:

  • Removed sticky post fix functionality (intentional removal per ticket requirements)
  • Updated linting configurations (backward compatible for development workflow)

@khleomix khleomix self-assigned this Jun 18, 2025
@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-261 WP6.8 Testing and Fixes

Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @khleomix - added one small push on at the end about our AI Disclosures, otherwise good to go.

@thatmitchcanter thatmitchcanter merged commit 0d00b71 into main Jun 19, 2025
4 checks passed
@thatmitchcanter thatmitchcanter deleted the feature/WDSBT-261-WP6.8-fixes branch June 19, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants