-
Notifications
You must be signed in to change notification settings - Fork 9
Feature/WDSBT-261 WP6.8 fixes #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: WDSBT-261 WP6.8 Testing and Fixes |
thatmitchcanter
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @khleomix - added one small push on at the end about our AI Disclosures, otherwise good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#WDSBT-261
Link to test
Test Locally
Description
This PR modernizes the WDS BT theme for WordPress 6.8 compatibility and PHP 8.3 support. The changes include:
.eslintrc.json
and.stylelintrc.json
to moderneslint.config.js
andstylelint.config.js
formatsinc/hooks/query-block-sticky-override.php
)Related Tickets & Documents
Fixes #WDSBT-261
Mobile & Desktop Screenshots/Recordings
🙅 No visual changes - this is a backend modernization and code quality improvement PR. All changes are internal to the theme's development workflow and configuration files.
Added to documentation?
Added tests?
Testing Instructions
npm run lint
to verify all linting passes without errorsnpm run lint:php
to confirm PHP 8.3 compatibilitynpm run build
to ensure the theme builds successfully.env
file:echo "VERSION=1.4.0" > .env
npm run version-update
Reviewer's Testing Checklist
As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.
npm run a11y
.[optional] Additional Reviewer Notes or Considerations?
Key Changes Summary:
Files of Note:
phpcs.xml.dist
- Updated for PHP 8.3 compatibilitystylelint.config.js
- New modern configuration.eslintrc.json
- Restored for WordPress compatibilityREADME.md
- Comprehensive documentation updates.env
- Added for version managementBreaking Changes: