Skip to content

Remove max width rule for core/code blocks #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

itsamoreh
Copy link
Contributor

Closes

#64

Link to test

coming soon...

Description

Removes the css rule that was setting a max width on all core/code blocks, breaking the alignment.

After this PR, the core/code blocks will respect the alignment set in editor.
2025-05-28-16 59 43

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Before

image

After

2025-05-28-16 58 38

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Add two core/code blocks to a page
  2. Set one of the blocks to alignfull
  3. Set the other block to alignwide
  4. Navigate to the frontend and observe that the code blocks respect the alignments

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@itsamoreh itsamoreh requested a review from khleomix as a code owner May 28, 2025 21:05
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @itsamoreh !

@thatmitchcanter thatmitchcanter merged commit 650d2f2 into main Jul 7, 2025
6 checks passed
@thatmitchcanter thatmitchcanter deleted the fix/#64-core-code-alignment branch July 7, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants