Skip to content

[spec] Update limits type in wasm-3.0 text format spec #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

keithw
Copy link
Member

@keithw keithw commented Mar 27, 2025

In memory64, the types of limits min and max were updated to u64 in the abstract syntax and the binary format specification. This updates the text format spec to match.

This is already tested by the wasm-3.0 tests, e.g. this assert_invalid test from memory.wast is an assert_malformed on the main branch:

(assert_invalid
  (module (memory 0x1_0000_0000))
  "memory size"
)

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit 27d5644 into WebAssembly:wasm-3.0 Mar 28, 2025
11 checks passed
@keithw keithw deleted the fix-text-limits branch March 29, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants